Allow range to propagate params

[kalofoli]

hi there,

I needed (and implemented) a parameters propagation feature for range.

The use case is pulling formulas or (un)formated text through valueRenderOptions.

Janis

[damgad]

Hey @kalofoli, what do you mean by "implemented"? Is there any PR open with the feature?

I've a related issue, I need to pass parameters (especially value_render_options) with the get_all_records and get_all_values functions. That's currently impossible.

[burnash]

@damgad Thanks for bringing this up. It's currently WIP. value_render_options has been added to get_all_values() in #648 and will be in PyPI with the next release.

In the meantime, you can use Worksheet.get() that was added in 3.3.0. It accepts value_render_option along with major_dimension and date_time_render_option.

get_all_records is a bit more involved. I have to take a look at it.

Let me know if this works for you.

[damgad]

Hey @burnash, thanks for your reply. #648 doesn't really fix the issue fully for me as get_all_records() function still doesn't have the needed parameter.

For now, I've just monkeypatched the gspread.models.Spreadsheet.values_get to always add params that I require. That also required a slight change to gspread.utils.numericise. That works fine for my kind of data.

The main issue/question with the get_all_records() would be the head row. Whether the render option parameter should also be applied to it. WDYT?

[kalofoli]

Hi there,
I just issued one. It is a long time ago, but should work, up to a conflict resolution I just had to do to merge.
@burnash, maybe you can give a second look.

[burnash]

@kalofoli sure, I'll take a look, thank you very much.
@damgad I see. Could you please create a new issue, and post a sample of your code and required changes? I'd be able to get a better picture of this.

[burnash]

Linking #740

[damgad]

@burnash Sure, I've just created #746