Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensible defaults for jco types #531

Open
ctaggart opened this issue Nov 28, 2024 · 2 comments
Open

sensible defaults for jco types #531

ctaggart opened this issue Nov 28, 2024 · 2 comments

Comments

@ctaggart
Copy link

Creating issue from #530 discussion:

@ctaggart: It would be nice if the wit directory exists, may be just default to use it. So jco types would do the equivelent of what jco types wit -o . does now.

@guybedford: that could be a sensible default actually, basically just if no --wit arg is provided assume wit. Would you consider posting a PR?

@ctaggart
Copy link
Author

ctaggart commented Dec 1, 2024

Where are you usually expecting interfaces to go? Should it be next to src in the root of the project? I tried putting it in src, but does not feel right:

image

@lachieh
Copy link
Contributor

lachieh commented Dec 5, 2024

I've been looking at this in a few places and there doesn't seem to be a generally accepted consensus across the popular packages that include generated types. A common pattern for generated types is a folder called types/<tool>/... or just /types/... and, personally, I think that'd suffice since there's a way to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants