remove unnecessary TaskListKind internal entity (#1023)

What changed?

Remove internal TaskListKind entity
use thrift entity directly (like everywhere else in the repo)
Why?

This complicates things and particularly for thrift deprecation

How did you test it?

Unit Test



Signed-off-by: Shijie Sheng <[email protected]>

Author: shijiesheng

src/main/java/com/uber/cadence/internal/worker/TaskListKind.java

@@ -25,6 +25,7 @@
 import com.uber.cadence.PollForDecisionTaskResponse;
 import com.uber.cadence.ServiceBusyError;
 import com.uber.cadence.TaskList;
+import com.uber.cadence.TaskListKind;
 import com.uber.cadence.common.BinaryChecksum;
 import com.uber.cadence.internal.metrics.MetricsTag;
 import com.uber.cadence.internal.metrics.MetricsType;
@@ -73,7 +74,7 @@ public PollForDecisionTaskResponse poll() throws TException {
     pollRequest.setIdentity(identity);
     pollRequest.setBinaryChecksum(BinaryChecksum.getBinaryChecksum());
 
-    TaskList tl = new TaskList().setName(taskList).setKind(taskListKind.toThrift());
+    TaskList tl = new TaskList().setName(taskList).setKind(taskListKind);
     pollRequest.setTaskList(tl);
 
     if (log.isDebugEnabled()) {

src/main/java/com/uber/cadence/internal/worker/WorkflowPollTask.java

@@ -18,6 +18,7 @@
 package com.uber.cadence.internal.worker;
 
 import com.uber.cadence.PollForDecisionTaskResponse;
+import com.uber.cadence.TaskListKind;
 import com.uber.cadence.serviceclient.IWorkflowService;
 import com.uber.m3.tally.Scope;
 import java.util.Objects;

src/main/java/com/uber/cadence/internal/worker/WorkflowPollTaskFactory.java

@@ -29,6 +29,7 @@
 import com.uber.cadence.RespondDecisionTaskFailedRequest;
 import com.uber.cadence.RespondQueryTaskCompletedRequest;
 import com.uber.cadence.ScheduleActivityTaskDecisionAttributes;
+import com.uber.cadence.TaskListKind;
 import com.uber.cadence.WorkflowExecution;
 import com.uber.cadence.WorkflowExecutionStartedEventAttributes;
 import com.uber.cadence.WorkflowQuery;
@@ -107,7 +108,7 @@ public void start() {
                   service,
                   domain,
                   taskList,
-                  TaskListKind.TASK_LIST_KIND_NORMAL,
+                  TaskListKind.NORMAL,
                   options.getMetricsScope(),
                   options.getIdentity()),
               pollTaskExecutor,

src/main/java/com/uber/cadence/internal/worker/WorkflowWorker.java

@@ -22,6 +22,7 @@
 import com.google.common.base.Preconditions;
 import com.google.common.base.Strings;
 import com.uber.cadence.PollForDecisionTaskResponse;
+import com.uber.cadence.TaskListKind;
 import com.uber.cadence.client.WorkflowClient;
 import com.uber.cadence.converter.DataConverter;
 import com.uber.cadence.converter.JsonDataConverter;
@@ -134,7 +135,7 @@ public WorkerFactory(WorkflowClient workflowClient, WorkerFactoryOptions factory
                     workflowClient.getService(),
                     workflowClient.getOptions().getDomain(),
                     getStickyTaskListName(),
-                    TaskListKind.TASK_LIST_KIND_STICKY,
+                    TaskListKind.STICKY,
                     stickyScope,
                     workflowClient.getOptions().getIdentity())
                 .get(),

src/main/java/com/uber/cadence/worker/WorkerFactory.java

@@ -80,7 +80,7 @@ public void setup() {
             mockService,
             "test-domain",
             "test-taskList",
-            TaskListKind.TASK_LIST_KIND_NORMAL,
+            TaskListKind.NORMAL,
             mockMetricScope,
             "test-identity");
   }