Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set warning level for build on Windows #179

Open
ronald-jaepel opened this issue Mar 15, 2024 · 1 comment
Open

Set warning level for build on Windows #179

ronald-jaepel opened this issue Mar 15, 2024 · 1 comment
Assignees
Labels

Comments

@ronald-jaepel
Copy link
Collaborator

Let's discuss at the next Core-Dev meeting which warnings we want to include in the output. In the past, Sam set the warning level to level 4 (commit) to show all warnings, to use this to eliminate sources of warnings. A decision we need to make as a team is: do we want to:

  • always show all warnings, or
  • should we reduce the warning level for e.g. Release builds and keep them for Debug or a specialized "maintenance" build setting.
@jbreue16
Copy link
Contributor

jbreue16 commented Jan 17, 2025

Dev call discussion:
We should first check how many and how easily we can fix the warnings.
Or exclude some warnings like the unsigned / signed int comparisons, which would also be an easy fix, just change to signed int.
Unsigned int discussion:
https://soundsoftware.ac.uk/c-pitfall-unsigned.html#:~:text=C%20and%20C%2B%2B%20are%20unusual,that%20can%20never%20be%20negative.
https://www.sandordargo.com/blog/2023/10/18/signed-unsigned-comparison-the-most-usual-violations
Und es gibt noch mehr, aber auch Gegenstimmen:
https://graphitemaster.github.io/aau/

@daklauss would be a good candidate to look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants