Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate GRM_FV edge cases #266

Open
1 of 6 tasks
jbreue16 opened this issue Aug 6, 2024 · 3 comments
Open
1 of 6 tasks

Investigate GRM_FV edge cases #266

jbreue16 opened this issue Aug 6, 2024 · 3 comments

Comments

@jbreue16
Copy link
Contributor

jbreue16 commented Aug 6, 2024

For the GRM we can choose only one cell for the particle discretization. This leads to some modeling edge cases, e.g. when particle diffusion becomes non limiting ($D_p\to1$). The latter case is similar to the LRMP, within some numerical tolerances. When $D_p = 0$, there is no diffusion into the particles, no matter the value for film diffusion.
This is a modeling edge case but good for testing, we should add that test.

Interestingly, we also found that the GRM performs better than the LRMP for our standard LWE example with around 25%.
This raises the question if this is generally the case and needs an explanation.

Thanks to @ronald-jaepel

TODO

  • investigate modeling edge cases for the GRM -> LRMP and GRM with npar=1 and $D_p=1.0$ give same results within numerical tolerances
  • Explain why $D_p = 0$ leads to no film diffusion. Shouldnt the interstitial volume still 'loose' concentration?
    • investigating this, we found that the magnitude of the film diffusion flux is very different between the LRMP and GRM
  • investigate performance difference between LRMP and GRM @AntoniaBerger
    • investigate solve files
  • Add test case GRM vs LRMP
@jbreue16 jbreue16 changed the title Add GRM_FV and LRMP equivalence test Investigate GRM_FV edge cases Aug 6, 2024
@AntoniaBerger
Copy link
Collaborator

AntoniaBerger commented Oct 9, 2024

The biggest time difference in the calculation between the two models can be seen in the linear solution functions of the respective units. This concerns the factorize function of the FactorizableBandMatrix class and the solve function of the Gmres class.
One possible option could therefore be that the linear solver of the LRMP can be optimized. This needs to be investigated further.
Here are the corresponding screenshots (1. GRM, 2. LRMP) :

grafik

grafik

@lieres
Copy link
Member

lieres commented Oct 15, 2024

Doesn't that just mean the time is being spent where it should?

@lieres
Copy link
Member

lieres commented Nov 19, 2024

Equation A.4 in Püttmann et al. (2016) explains why the discretized flux becomes zero for $k_f \rightarrow 0$ or $D_p \rightarrow 0$.

I would still like to better understand the root cause of the different runtimes. Does the linear solver need more iterations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

4 participants