Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify time derivative Jacobian test #330

Open
AntoniaBerger opened this issue Nov 27, 2024 · 0 comments
Open

Modify time derivative Jacobian test #330

AntoniaBerger opened this issue Nov 27, 2024 · 0 comments
Labels
good first issue Good starting point for newcomers, easy to fix test

Comments

@AntoniaBerger
Copy link
Collaborator

AntoniaBerger commented Nov 27, 2024

To avoid the bug described in #309 in the future, we should add a test that checks addTimeDerivativeJacobian independently of multipyWithDerivativeJacobian.

Short summary:

  • The time derivative Jacobian test does not use the addTimeDerivativeJacobian function due to performance advantages. It uses the multiplyWithDerivativeJacobian function, where setting up and multiplying by a vector is done in a loop.
  • addTimeDerivativeJacobian is only called when testing for consistent initialisation where $\alpha =1$, so that mistakes with $\alpha$ are not missed.

This is discussed in more detail in #326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good starting point for newcomers, easy to fix test
Projects
Status: Todo
Development

No branches or pull requests

1 participant