Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build from source enabling threading gives errors #353

Closed
spdavern opened this issue Jan 3, 2025 · 2 comments · Fixed by #354
Closed

Build from source enabling threading gives errors #353

spdavern opened this issue Jan 3, 2025 · 2 comments · Fixed by #354
Labels

Comments

@spdavern
Copy link

spdavern commented Jan 3, 2025

I've needed to build CADET-Core from source because the Conda package does not appear to be available for my machine. I can successfully build from source following the documentation with defaults which I believe do not enable multi-threading. However, if I attempt to enable multi-threading during the build, it gives errors.

Expected Behavior

Build from source adding -DENABLE_THREADING=ON into the prescribed cmake builds successfully and enables multi-threading support.

Actual Behavior

Build gives errors:
Image

Steps to Reproduce the Problem

Follow instructions in BUILD-OSX.md

  1. Use cmake -DCMAKE_INSTALL_PREFIX="<ROOT>/install" -DENABLE_THREADING=ON ../ as suggested in this forum discussion to enable multithreading.
  2. 73% through the cmake gives the error above.

Specifications

  • Version: 5.0.3
  • Platform: osx-arm64 - Apple Macbook Pro with the Apple M3 Max chip
  • Subsystem:
    ▶ cmake --version
    cmake version 3.31.3
    ▶ gcc --version
    Apple clang version 16.0.0 (clang-1600.0.26.6)
    Target: arm64-apple-darwin23.6.0
    Thread model: posix
    ▶ brew info hdf5
    ==> hdf5: stable 1.14.5 (bottled)
    ▶ brew info tbb
    ==> tbb: stable 2022.0.0 (bottled)
    ▶ brew info eigen
    ==> eigen: stable 3.4.0 (bottled), HEAD
@jbreue16
Copy link
Contributor

jbreue16 commented Jan 3, 2025

Hi @spdavern , thanks for submitting the issue here ! :)

I think theres an easy fix for this, can you please try and build the code provided by the PR #354 ?

@jbreue16 jbreue16 added the bug label Jan 3, 2025
@spdavern
Copy link
Author

spdavern commented Jan 3, 2025

Thank you! You'll see I had to make a similar change to 1 other file - see comment. However, with those changes I was able to build with -DENABLE_THREADING=ON. Installing gave an apparently functional, multi-thread-capable cadet-cli.

@github-project-automation github-project-automation bot moved this from Todo to Done in CADET-Project Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants