This is a meta issue to track all the interface changes we want to have for v6 ### open - inconsistent FV vs DG interface: for units with npartype=0, FV needs total porosity, DG needs col_porosity, the latter should be used - #510 - #126 - #77 - #381 - https://github.com/cadet/CADET-Specification/issues/5 - rename inlet and outlet unit operations to source and sink unit operations (having an outlet and an inlet, respectively) - fix inconsistencies - consistent output for DG and FV particles: ordering of state - #631 - change `WRITE_SOLUTION_PARTICLE` to `WRITE_SOLUTION_PORE` - `BINDING_MODEL` instead of `ADSORPTION_MODEL`, which is consistent with our modeling paper? - #614 - double check all discretization fields: e.g. `PAR_NELEM` for DG but `NCELLS` for FV - double check: what happens if has_film_diffusion=false but has_pore_diffusion=true? should throw an exception, model does not exist ### done - https://github.com/cadet/CADET-Specification/issues/4 -> fixed by #414 - #284 - #589 - https://github.com/cadet/CADET-Core/pull/591
This is a meta issue to track all the interface changes we want to have for v6
open
SPLIT_COMPONENT_DATAonly applies to outlet solution #631WRITE_SOLUTION_PARTICLEtoWRITE_SOLUTION_POREBINDING_MODELinstead ofADSORPTION_MODEL, which is consistent with our modeling paper?PAR_NELEMfor DG butNCELLSfor FVdone
NPARTYPEmandatory for column UO #589CRY_MODEmandatory for crystallization models #591