Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative units #51

Open
lieres opened this issue Jun 8, 2020 · 6 comments
Open

Alternative units #51

lieres opened this issue Jun 8, 2020 · 6 comments

Comments

@lieres
Copy link
Member

lieres commented Jun 8, 2020

CADET is currently based on the SI unit system and this should always be the deafult standard. However, it might be convenient for many users to be able to specify different units for each individual parameter, e.g. from the CGS system.

This could be implemented by adding an additonal field to the HDF5 file that specifies the unit and converting the corresponding values upon read/ write. If the unit field is missing, SI units are used.

@sleweke
Copy link
Contributor

sleweke commented Nov 2, 2020

CADET is fully unit-agnostic. That is, you can use any unit system you want as long as you are consistent.
For example, you can use cm instead of m everywhere, or g instead of mol.

@Immudzen
Copy link
Contributor

Immudzen commented Nov 3, 2020

I think we would have to work out other unit systems to tell people what a fully consistent unit system is because it is not that simple. If you use g instead of mol you also change the SMA neutrality condition to grams instead of countable numbers and that is going to give some weird numbers. If you write your flow in L/min then your dispersion is in decimeter^2/min. Producing a completely consistent unit system that works with the binding models is not going to be trivial and encouraging this is going to end up with a lot of failed simulations due to non-obvious unit problems.

@lieres
Copy link
Member Author

lieres commented Nov 3, 2020

Even though that is generally possible, I would refrain from using g in the units. However, I agree that it might be helpful to demonstrate computations in a different unit system. I would suggest to use dimensionless groups as an example, i.e. Peclet number in place of the dispersion coefficient, etc.

@ronald-jaepel
Copy link
Collaborator

Can this be closed?

@lieres
Copy link
Member Author

lieres commented Jun 12, 2024

I would leave it open. There are packages that would allow us to associate input and output values with units, so users can easily convert between unit systems.

@schmoelder
Copy link
Contributor

Maybe this would be better suited for CADET-Process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

5 participants