Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for single unit operation #35

Open
schmoelder opened this issue Dec 3, 2024 · 1 comment
Open

Add tests for single unit operation #35

schmoelder opened this issue Dec 3, 2024 · 1 comment
Milestone

Comments

@schmoelder
Copy link
Contributor

A but was discovered in #28, where the solution was not returned correctly if the simulation only contained a single unit operation. This was fixed but unfortunately, we currently don't have tests for single-unit-operation systems (because currently we mainly use the LWE function).

We should improve this in the future.

@ronald-jaepel since you reported the issue, could you please provide a MRE?

@hannahlanzrath hannahlanzrath mentioned this issue Dec 4, 2024
@schmoelder schmoelder added this to the v1.1.0 milestone Dec 12, 2024
@ronald-jaepel ronald-jaepel modified the milestones: v1.1.0, v1.2.0 Feb 24, 2025
@schmoelder
Copy link
Contributor Author

schmoelder commented Feb 24, 2025

After discussion with @ronald-jaepel , we decided to postpone this issue a bit. We should re-evaluate whether we want to continue using createLWE from CADET-Core to parametrize our tests or whether it makes sense to migrate some of the functionality out of C++ to improve the usability / flexibility. See also #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants