Skip to content

Ask upstream pic for a canister-log hook to remove the serverProcess cast #655

Description

@Kamirus

cli/commands/replica.ts streams canister logs by parsing the PocketIC server's stderr for [Canister <id>] lines and routing them to per-canister streams. Upstream @dfinity/pic offers only all-or-nothing (showCanisterLogs pipes everything to the parent's stderr), so cli/helpers/pocket-ic-client.ts reaches the process through a documented cast — serverProcess is TS-private but present at runtime.

It works and is contained in one helper, but it depends on an implementation detail that an upstream refactor could remove without warning. A public stderr accessor or an onCanisterLog callback upstream would let mops delete the cast.

Not urgent — the cast is exercised by mops replica and the replica test path, so a break would surface immediately rather than silently.

Metadata

Metadata

Assignees

No one assigned

    Labels

    clidependenciesPull requests that update a dependency file

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions