DirectoryAliases.MakeAbsolute computes the wrong path if the path contains ..

[paulomorgado]

Prerequisites

• I have written a descriptive issue title
• I have searched issues to ensure it has not already been reported

Cake runner

Cake Frosting

Cake version

5.0.0

Operating system

Windows

Operating system architecture

x64

CI Server

No response

What are you seeing?

var b = context.MakeAbsolute(context.Directory(".")); // C:/repos/repo/build
var d = context.MakeAbsolute(b.Combine(new DirectoryPath("../Dashboards"))); // C:/repos/repo/build/../Dashboards

What is expected?

var b = context.MakeAbsolute(context.Directory(".")); // C:/repos/repo/build
var d = context.MakeAbsolute(b.Combine(new DirectoryPath("../Dashboards"))); // C:/repos/repo/build/Dashboards

Steps to Reproduce

var b = context.MakeAbsolute(context.Directory("."));
var d = context.MakeAbsolute(b.Combine(new DirectoryPath("../Dashboards")));

Output log

No response

[patriksvensson]

This is by design (as I implemented it back in the days), and the path (containing ..) is a valid path, so saying "invalid" is stretching it a bit. "Not what I expected" is probably better choice of words here 🙂

[paulomorgado]

Fair enough.

But how about this?

context.Environment.WorkingDirectory = context.MakeAbsolute(context.Directory("C:/temp/repo/build"));
var b = context.MakeAbsolute(context.Directory(".")); // C:/temp/repo/build
var d = context.MakeAbsolute(b.Combine(new DirectoryPath("../Dashboards"))); // C:/temp/repo/build/../Dashboards
var f = context.File("C:/repos/repo/build/Dashboards/file.ext"); // C:/temp/repo/build/Dashboards/file.ext
var r = context.MakeRelative(f, d); // ../../../../../repos/repo/build/Dashboards/file.ext
var a = context.MakeAbsolute(r); // C:/repos/repo/build/Dashboards/file.ext

I this code, shouldn't r b just tile.ext? The resulting value is higher than the file system's root.

Is there a way to normalize the path and get rid of all . and ..?

[paulomorgado]

I think I found out what I was looking for: Collapse method.

Using Collapse on RelativePathResolver.Resolve would make it easier and more correct.

[patriksvensson]

You might be able to use the collapse method on DirectoryPath as well: https://cakebuild.net/api/Cake.Core.IO/DirectoryPath/4CE45D81