Skip to content

Commit 9d252e8

Browse files
zfurtakzfurtak
committed
Changed [] to at()
1 parent 4c9a3fb commit 9d252e8

File tree

255 files changed

+43153
-992
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

255 files changed

+43153
-992
lines changed

‎.eslintrc.js

+6
Original file line numberDiff line numberDiff line change
@@ -289,5 +289,11 @@ module.exports = {
289289
'rulesdir/use-periods-for-error-messages': 'error',
290290
},
291291
},
292+
{
293+
files: ['*.ts', '*.tsx'],
294+
rules: {
295+
'rulesdir/prefer-at': 'error',
296+
},
297+
},
292298
],
293299
};

‎.github/actions/javascript/authorChecklist/authorChecklist.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ function partitionWithChecklist(body: string): string[] {
5454
async function getNumberOfItemsFromAuthorChecklist(): Promise<number> {
5555
const response = await fetch(pathToAuthorChecklist);
5656
const fileContents = await response.text();
57-
const checklist = partitionWithChecklist(fileContents)[1];
57+
const checklist = partitionWithChecklist(fileContents).at(1) ?? '';
5858
const numberOfChecklistItems = (checklist.match(/\[ \]/g) ?? []).length;
5959
return numberOfChecklistItems;
6060
}

‎.github/actions/javascript/authorChecklist/index.js

+10-6
Original file line numberDiff line numberDiff line change
@@ -16771,7 +16771,7 @@ function partitionWithChecklist(body) {
1677116771
async function getNumberOfItemsFromAuthorChecklist() {
1677216772
const response = await fetch(pathToAuthorChecklist);
1677316773
const fileContents = await response.text();
16774-
const checklist = partitionWithChecklist(fileContents)[1];
16774+
const checklist = partitionWithChecklist(fileContents).at(1) ?? '';
1677516775
const numberOfChecklistItems = (checklist.match(/\[ \]/g) ?? []).length;
1677616776
return numberOfChecklistItems;
1677716777
}
@@ -17180,7 +17180,11 @@ class GithubUtils {
1718017180
if (data.length > 1) {
1718117181
throw new Error(`Found more than one ${CONST_1.default.LABELS.STAGING_DEPLOY} issue.`);
1718217182
}
17183-
return this.getStagingDeployCashData(data[0]);
17183+
const issue = data.at(0);
17184+
if (!issue) {
17185+
throw new Error(`Found an undefined ${CONST_1.default.LABELS.STAGING_DEPLOY} issue.`);
17186+
}
17187+
return this.getStagingDeployCashData(issue);
1718417188
});
1718517189
}
1718617190
/**
@@ -17258,7 +17262,7 @@ class GithubUtils {
1725817262
}
1725917263
internalQASection = internalQASection[1];
1726017264
const internalQAPRs = [...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${CONST_1.default.PULL_REQUEST_REGEX.source})`, 'g'))].map((match) => ({
17261-
url: match[2].split('-')[0].trim(),
17265+
url: match[2].split('-').at(0)?.trim() ?? '',
1726217266
number: Number.parseInt(match[3], 10),
1726317267
isResolved: match[1] === 'x',
1726417268
}));
@@ -17342,7 +17346,7 @@ class GithubUtils {
1734217346
* Fetch all pull requests given a list of PR numbers.
1734317347
*/
1734417348
static fetchAllPullRequests(pullRequestNumbers) {
17345-
const oldestPR = pullRequestNumbers.sort((a, b) => a - b)[0];
17349+
const oldestPR = pullRequestNumbers.sort((a, b) => a - b).at(0);
1734617350
return this.paginate(this.octokit.pulls.list, {
1734717351
owner: CONST_1.default.GITHUB_OWNER,
1734817352
repo: CONST_1.default.APP_REPO,
@@ -17416,7 +17420,7 @@ class GithubUtils {
1741617420
repo: CONST_1.default.APP_REPO,
1741717421
workflow_id: workflow,
1741817422
})
17419-
.then((response) => response.data.workflow_runs[0]?.id);
17423+
.then((response) => response.data.workflow_runs.at(0)?.id ?? -1);
1742017424
}
1742117425
/**
1742217426
* Generate the URL of an New Expensify pull request given the PR number.
@@ -17484,7 +17488,7 @@ class GithubUtils {
1748417488
per_page: 1,
1748517489
name: artifactName,
1748617490
})
17487-
.then((response) => response.data.artifacts[0]);
17491+
.then((response) => response.data.artifacts.at(0));
1748817492
}
1748917493
/**
1749017494
* Given an artifact ID, returns the download URL to a zip file containing the artifact.

‎.github/actions/javascript/awaitStagingDeploys/index.js

+9-5
Original file line numberDiff line numberDiff line change
@@ -12421,7 +12421,11 @@ class GithubUtils {
1242112421
if (data.length > 1) {
1242212422
throw new Error(`Found more than one ${CONST_1.default.LABELS.STAGING_DEPLOY} issue.`);
1242312423
}
12424-
return this.getStagingDeployCashData(data[0]);
12424+
const issue = data.at(0);
12425+
if (!issue) {
12426+
throw new Error(`Found an undefined ${CONST_1.default.LABELS.STAGING_DEPLOY} issue.`);
12427+
}
12428+
return this.getStagingDeployCashData(issue);
1242512429
});
1242612430
}
1242712431
/**
@@ -12499,7 +12503,7 @@ class GithubUtils {
1249912503
}
1250012504
internalQASection = internalQASection[1];
1250112505
const internalQAPRs = [...internalQASection.matchAll(new RegExp(`- \\[([ x])]\\s(${CONST_1.default.PULL_REQUEST_REGEX.source})`, 'g'))].map((match) => ({
12502-
url: match[2].split('-')[0].trim(),
12506+
url: match[2].split('-').at(0)?.trim() ?? '',
1250312507
number: Number.parseInt(match[3], 10),
1250412508
isResolved: match[1] === 'x',
1250512509
}));
@@ -12583,7 +12587,7 @@ class GithubUtils {
1258312587
* Fetch all pull requests given a list of PR numbers.
1258412588
*/
1258512589
static fetchAllPullRequests(pullRequestNumbers) {
12586-
const oldestPR = pullRequestNumbers.sort((a, b) => a - b)[0];
12590+
const oldestPR = pullRequestNumbers.sort((a, b) => a - b).at(0);
1258712591
return this.paginate(this.octokit.pulls.list, {
1258812592
owner: CONST_1.default.GITHUB_OWNER,
1258912593
repo: CONST_1.default.APP_REPO,
@@ -12657,7 +12661,7 @@ class GithubUtils {
1265712661
repo: CONST_1.default.APP_REPO,
1265812662
workflow_id: workflow,
1265912663
})
12660-
.then((response) => response.data.workflow_runs[0]?.id);
12664+
.then((response) => response.data.workflow_runs.at(0)?.id ?? -1);
1266112665
}
1266212666
/**
1266312667
* Generate the URL of an New Expensify pull request given the PR number.
@@ -12725,7 +12729,7 @@ class GithubUtils {
1272512729
per_page: 1,
1272612730
name: artifactName,
1272712731
})
12728-
.then((response) => response.data.artifacts[0]);
12732+
.then((response) => response.data.artifacts.at(0));
1272912733
}
1273012734
/**
1273112735
* Given an artifact ID, returns the download URL to a zip file containing the artifact.

‎.github/actions/javascript/bumpVersion/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3536,7 +3536,7 @@ exports.updateAndroidVersion = updateAndroidVersion;
35363536
* Updates the CFBundleShortVersionString and the CFBundleVersion.
35373537
*/
35383538
function updateiOSVersion(version) {
3539-
const shortVersion = version.split('-')[0];
3539+
const shortVersion = version.split('-').at(0);
35403540
const cfVersion = version.includes('-') ? version.replace('-', '.') : `${version}.0`;
35413541
console.log('Updating iOS', `CFBundleShortVersionString: ${shortVersion}`, `CFBundleVersion: ${cfVersion}`);
35423542
// Update Plists

0 commit comments

Comments
 (0)