Skip to content

Commit 4c80678

Browse files
committed
fix: fix broken nitro view template
1 parent 8a4de96 commit 4c80678

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/build-templates.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,20 +145,20 @@ jobs:
145145
run: |
146146
# Build Android for only some matrices to skip redundant builds
147147
if [[ ${{ matrix.os }} =~ ubuntu ]]; then
148-
if [[ ${{ matrix.type.name }} == *-view && ${{ matrix.type.language }} == *-objc ]] || [[ ${{ matrix.type.name }} == *-module && ${{ matrix.type.language }} == *-objc ]]; then
148+
if [[ ${{ matrix.type.name }} == *-view && ${{ matrix.type.language }} == *-objc ]] || [[ ${{ matrix.type.name }} == *-module && ${{ matrix.type.language }} == *-objc ]] || [[ ${{ matrix.type.name }} == nitro-* ]]; then
149149
echo "android_build=1" >> $GITHUB_ENV
150150
fi
151151
fi
152152
153153
# Build iOS for only some matrices to skip redundant builds
154154
if [[ ${{ matrix.os }} =~ macos ]]; then
155-
if [[ ${{ matrix.type.name }} == *-view && ${{ matrix.type.language }} == kotlin-* ]] || [[ ${{ matrix.type.name }} == *-module && ${{ matrix.type.language }} == kotlin-* ]]; then
155+
if [[ ${{ matrix.type.name }} == *-view && ${{ matrix.type.language }} == kotlin-* ]] || [[ ${{ matrix.type.name }} == *-module && ${{ matrix.type.language }} == kotlin-* ]] || [[ ${{ matrix.type.name }} == nitro-* ]]; then
156156
echo "ios_build=1" >> $GITHUB_ENV
157157
fi
158158
fi
159159
160160
- name: Generate nitrogen code
161-
if: matrix.type == 'nitro-view' || matrix.type == 'nitro-module'
161+
if: matrix.type.name == 'nitro-view' || matrix.type.name == 'nitro-module'
162162
working-directory: ${{ env.work_dir }}
163163
run: yarn nitrogen
164164

packages/create-react-native-library/templates/nitro-view/android/src/main/java/com/margelo/nitro/{%- project.package_dir %}/{%- project.name %}Package.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
package com.margelo.nitro.<%- project.package %>
22

3-
import com.facebook.react.TurboReactPackage
3+
import com.facebook.react.BaseReactPackage
44
import com.facebook.react.bridge.NativeModule
55
import com.facebook.react.bridge.ReactApplicationContext
66
import com.facebook.react.module.model.ReactModuleInfoProvider
77
import com.facebook.react.uimanager.ViewManager
88

9-
import <%- project.package_cpp -%>.views.Hybrid<%- project.name -%>Manager
9+
import com.margelo.nitro.<%- project.package %>.views.Hybrid<%- project.name -%>Manager
1010

11-
class <%- project.name -%>Package : TurboReactPackage() {
11+
class <%- project.name -%>Package : BaseReactPackage() {
1212
override fun getModule(name: String, reactContext: ReactApplicationContext): NativeModule? {
1313
return null
1414
}

0 commit comments

Comments
 (0)