From 92071c65712be73e709611c1c11bb1cfe5d2aada Mon Sep 17 00:00:00 2001 From: PEDRO DIEZ GARCIA Date: Tue, 5 Aug 2025 17:42:27 +0200 Subject: [PATCH 1/3] Rename CUSTOMER_INSIGHTS.IDENTIFIERS_MISMATCH code --- code/API_definitions/customer-insights.yaml | 8 ++++---- .../customer-insights-retrieveScoring.feature | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/code/API_definitions/customer-insights.yaml b/code/API_definitions/customer-insights.yaml index b645b7c..74e1ab7 100644 --- a/code/API_definitions/customer-insights.yaml +++ b/code/API_definitions/customer-insights.yaml @@ -409,7 +409,7 @@ components: - An identifier is not included in the request and the device or phone number identification cannot be derived from the 3-legged access token ("code": "MISSING_IDENTIFIER","message": "The phone number cannot be identified.") - An explicit identifier is provided when a device or phone number has already been identified from the access token ("code": "UNNECESSARY_IDENTIFIER","message": "The phone number is already identified by the access token.") - Provided `scoringType` value is not supported. (`"code": "CUSTOMER_INSIGHTS.SCALE_TYPE_NOT_SUPPORTED","message": "Indicated parameter scoringType is not supported."`) - - Provided `idDocument` is not consistent with the phone number. (`"code": "CUSTOMER_INSIGHTS.IDENTIFIERS_MISMATCH","message": "Provided idDocument is not consistent with the phone number."`) + - Provided `idDocument` is not consistent with the phone number. (`"code": "CUSTOMER_INSIGHTS.ID_DOCUMENT_MISMATCH","message": "Provided idDocument is not consistent with the phone number."`) - Provided `idDocument` field is not supported. (`"code": "CUSTOMER_INSIGHTS.ID_DOCUMENT_NOT_SUPPORTED","message": "Indicated parameter idDocument is not supported"`) - Required `idDocument` field and it is not provided. (`"code": "CUSTOMER_INSIGHTS.ID_DOCUMENT_REQUIRED","message": "The idDocument is required to perform the properties validation."`) headers: @@ -431,7 +431,7 @@ components: - MISSING_IDENTIFIER - UNNECESSARY_IDENTIFIER - CUSTOMER_INSIGHTS.SCALE_TYPE_NOT_SUPPORTED - - CUSTOMER_INSIGHTS.IDENTIFIERS_MISMATCH + - CUSTOMER_INSIGHTS.ID_DOCUMENT_MISMATCH - CUSTOMER_INSIGHTS.ID_DOCUMENT_NOT_SUPPORTED - CUSTOMER_INSIGHTS.ID_DOCUMENT_REQUIRED examples: @@ -459,11 +459,11 @@ components: status: 422 code: CUSTOMER_INSIGHTS.SCALE_TYPE_NOT_SUPPORTED message: Indicated parameter `scoringType` is not supported. - GENERIC_422_IDENTIFIERS_MISMATCH: + GENERIC_422_ID_DOCUMENT_MISMATCH: description: Error when provided `idDocument` is not consistent with the phone number. value: status: 422 - code: CUSTOMER_INSIGHTS.IDENTIFIERS_MISMATCH + code: CUSTOMER_INSIGHTS.ID_DOCUMENT_MISMATCH message: Provided `idDocument` is not consistent with the phone number. GENERIC_422_ID_DOCUMENT_NOT_SUPPORTED: description: Error when `idDocument` field is not supported diff --git a/code/Test_definitions/customer-insights-retrieveScoring.feature b/code/Test_definitions/customer-insights-retrieveScoring.feature index b314ab3..c97d3f5 100644 --- a/code/Test_definitions/customer-insights-retrieveScoring.feature +++ b/code/Test_definitions/customer-insights-retrieveScoring.feature @@ -203,7 +203,7 @@ Feature: CAMARA Customer Insights API, v0.2.0-rc.1 - Operation retrieveScoring When the request "retrieveScoring" is sent Then the response status code is 422 And the response property "$.status" is 422 - And the response property "$.code" is "CUSTOMER_INSIGHTS.IDENTIFIERS_MISMATCH" + And the response property "$.code" is "CUSTOMER_INSIGHTS.ID_DOCUMENT_MISMATCH" And the response property "$.message" contains a user friendly text @retrieve_scoring_422.03_id_document_not_supported @@ -277,4 +277,4 @@ Feature: CAMARA Customer Insights API, v0.2.0-rc.1 - Operation retrieveScoring ############################## ##END -############################## \ No newline at end of file +############################## From 9b2ef53c7a2c9275d078768b706084a4b7bc7e4e Mon Sep 17 00:00:00 2001 From: PEDRO DIEZ GARCIA Date: Thu, 21 Aug 2025 13:42:52 +0200 Subject: [PATCH 2/3] apply_suggestions_from_Rafal_comment --- code/API_definitions/customer-insights.yaml | 12 ++++++------ .../customer-insights-retrieveScoring.feature | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/code/API_definitions/customer-insights.yaml b/code/API_definitions/customer-insights.yaml index 3876c07..a1c9a0e 100644 --- a/code/API_definitions/customer-insights.yaml +++ b/code/API_definitions/customer-insights.yaml @@ -409,7 +409,7 @@ components: - An identifier is not included in the request and the device or phone number identification cannot be derived from the 3-legged access token ("code": "MISSING_IDENTIFIER","message": "The phone number cannot be identified.") - An explicit identifier is provided when a device or phone number has already been identified from the access token ("code": "UNNECESSARY_IDENTIFIER","message": "The phone number is already identified by the access token.") - Provided `scoringType` value is not supported. (`"code": "CUSTOMER_INSIGHTS.SCALE_TYPE_NOT_SUPPORTED","message": "Indicated parameter scoringType is not supported."`) - - Provided `idDocument` is not consistent with the phone number. (`"code": "CUSTOMER_INSIGHTS.ID_DOCUMENT_MISMATCH","message": "Provided idDocument is not consistent with the phone number."`) + - Provided `idDocument` is not consistent with the phone number. (`"code": "CUSTOMER_INSIGHTS.INVALID_IDENTIFIERS","message": "The request contains invalid data."`) - Provided `idDocument` field is not supported. (`"code": "CUSTOMER_INSIGHTS.ID_DOCUMENT_NOT_SUPPORTED","message": "Indicated parameter idDocument is not supported"`) - Required `idDocument` field and it is not provided. (`"code": "CUSTOMER_INSIGHTS.ID_DOCUMENT_REQUIRED","message": "The idDocument is required to perform the properties validation."`) headers: @@ -431,7 +431,7 @@ components: - MISSING_IDENTIFIER - UNNECESSARY_IDENTIFIER - CUSTOMER_INSIGHTS.SCALE_TYPE_NOT_SUPPORTED - - CUSTOMER_INSIGHTS.ID_DOCUMENT_MISMATCH + - CUSTOMER_INSIGHTS.INVALID_IDENTIFIERS - CUSTOMER_INSIGHTS.ID_DOCUMENT_NOT_SUPPORTED - CUSTOMER_INSIGHTS.ID_DOCUMENT_REQUIRED examples: @@ -459,12 +459,12 @@ components: status: 422 code: CUSTOMER_INSIGHTS.SCALE_TYPE_NOT_SUPPORTED message: Indicated parameter `scoringType` is not supported. - GENERIC_422_ID_DOCUMENT_MISMATCH: - description: Error when provided `idDocument` is not consistent with the phone number. + GENERIC_422_INVALID_IDENTIFIERS: + description: The request contains invalid data identifying customer value: status: 422 - code: CUSTOMER_INSIGHTS.ID_DOCUMENT_MISMATCH - message: Provided `idDocument` is not consistent with the phone number. + code: CUSTOMER_INSIGHTS.INVALID_IDENTIFIERS + message: The request contains invalid data. GENERIC_422_ID_DOCUMENT_NOT_SUPPORTED: description: Error when `idDocument` field is not supported value: diff --git a/code/Test_definitions/customer-insights-retrieveScoring.feature b/code/Test_definitions/customer-insights-retrieveScoring.feature index d872ab6..75a3148 100644 --- a/code/Test_definitions/customer-insights-retrieveScoring.feature +++ b/code/Test_definitions/customer-insights-retrieveScoring.feature @@ -203,7 +203,7 @@ Feature: CAMARA Customer Insights API, v0.2.0-rc.1 - Operation retrieveScoring When the request "retrieveScoring" is sent Then the response status code is 422 And the response property "$.status" is 422 - And the response property "$.code" is "CUSTOMER_INSIGHTS.ID_DOCUMENT_MISMATCH" + And the response property "$.code" is "CUSTOMER_INSIGHTS.INVALID_IDENTIFIERS" And the response property "$.message" contains a user friendly text @retrieve_scoring_422.03_id_document_not_supported_three_legged From 4f185289aebd759521db859605787e8bcbb3f26a Mon Sep 17 00:00:00 2001 From: PEDRO DIEZ GARCIA Date: Thu, 21 Aug 2025 17:10:59 +0200 Subject: [PATCH 3/3] align_main