Skip to content

Commit eb865df

Browse files
authored
Merge pull request #55 from AndreyIslentiev/CAM-3770-accessibility-improvements
[CAM-3770] Directory accessibility improvements
2 parents 7cf11e1 + 68471e2 commit eb865df

File tree

1 file changed

+7
-5
lines changed
  • inc/plugins/cp-directory/cp-directory-files/blocks/cp-dir/template-parts

1 file changed

+7
-5
lines changed

inc/plugins/cp-directory/cp-directory-files/blocks/cp-dir/template-parts/directory.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
$taxonomies_filters = $data->get_taxonomy_filters();
2222

2323
$posts_per_page = $data->get_posts_per_page( $entries_count );
24-
$aria_label = apply_filters( 'cp_dir_directory_label', $label, $data );
2524
$filters_logic = apply_filters( 'cp_dir_filters_logic', ( isset( $atts['filters_logic'] ) && $atts['filters_logic'] ) ? $atts['filters_logic'] : '' );
2625
$pagination = apply_filters( 'cp_dir_pagination', ( $posts_per_page && isset( $atts['pagination'] ) && $atts['pagination'] ) ? true : false, $data );
2726

@@ -30,7 +29,7 @@
3029
$content_class .= ' cp-dir-content--no-results';
3130
}
3231
?>
33-
<div class="<?php echo esc_attr( $class_name ); ?>" id="<?php echo esc_attr( $dir_id ); ?>" aria-label="<?php echo esc_attr( $aria_label ); ?>" data-source="<?php echo esc_attr( $data->post_type_object->name ); ?>" data-filters-logic="<?php echo esc_attr( $filters_logic ); ?>">
32+
<div class="<?php echo esc_attr( $class_name ); ?>" id="<?php echo esc_attr( $dir_id ); ?>" data-source="<?php echo esc_attr( $data->post_type_object->name ); ?>" data-filters-logic="<?php echo esc_attr( $filters_logic ); ?>">
3433
<?php
3534
if ( $filters || $taxonomies_filters ) {
3635
?>
@@ -39,15 +38,18 @@
3938
<legend class="cp-dir-sr-info screen-reader-text">
4039
<?php echo apply_filters( 'cp_dir_directory_refresh_info', __( 'Items will instantly refresh upon filtering.', 'cp-dir' ), $data ); ?>
4140
</legend>
42-
41+
4342
<?php include( apply_filters( 'cp_dir_path_directory_filters', $this->dir . '/cp-directory-files/blocks/cp-dir/template-parts/directory-filters.php', $data ) ); ?>
4443
</fieldset>
4544
</form>
4645
<?php
4746
}
4847
?>
49-
<div class="<?php echo esc_attr( apply_filters( 'cp_dir_content_class', $content_class, $data ) ); ?>" id="<?php echo esc_attr( $dir_id ); ?>-content" aria-label="<?php echo esc_attr( apply_filters( 'cp_dir_directory_entries_label', sprintf( __( '%s Entries', 'cp-dir' ), $label ), $data ) ); ?>">
50-
<div class="cp-dir-sr-info cp-dir-sr-info-count screen-reader-text" aria-live="polite" aria-atomic="true" aria-relevant="all">
48+
<div class="<?php echo esc_attr( apply_filters( 'cp_dir_content_class', $content_class, $data ) ); ?>" id="<?php echo esc_attr( $dir_id ); ?>-content">
49+
<?php
50+
$has_filters = $filters || $taxonomies_filters;
51+
?>
52+
<div class="cp-dir-sr-info cp-dir-sr-info-count screen-reader-text" <?php echo $has_filters || $pagination ? 'aria-live="polite"' : ''; ?> aria-atomic="true" aria-relevant="all">
5153
<?php printf( __( '%s results found.', 'cp-dir' ), '<span class="cp-dir-sr-info-count-number">' . $entries_count . '</span>' ); ?>
5254
<?php
5355
if ( $posts_per_page ) {

0 commit comments

Comments
 (0)