net/sysconfig: do not remove all existing settings of /etc/sysconfig/network #5991
Conversation
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.) |
github-actions
bot
added
the
stale-pr
ani-sinha
force-pushed
the
zeroconf-fix
branch
from
fdd69f7 to
8cf8370
Compare
…network In some distros, /etc/sysconfig/network may have important configurations that are necessary for the instance to come up. For example, centos based distros write NOZEROCONF=yes in /etc/sysconfig/network for some instances that require zeroconf to be disabled. Removing these customizations would prevent the instance to come up. So leave the customizations in /etc/sysconfig/network intact except those that we are interested in. Fixes canonicalGH-5990 Signed-off-by: Ani Sinha <anisinha@redhat.com>
ani-sinha
force-pushed
the
zeroconf-fix
branch
from
8cf8370 to
bf34bbe
Compare
Tagging @TheRealFalcon as the message says 😃 |
TheRealFalcon
removed
the
stale-pr
|
QE tested this change internally and it seems the change fixed the issue. |
|
@TheRealFalcon any idea when this will me merged? We have some internal deadline coming up and this issue is a regression, hence will have to be fixed. |
Proposed Commit Message
In some distros,
/etc/sysconfig/networkmay have important configurations that are necessary for the instance to come up. For example, centos based distros writeNOZEROCONF=yesin/etc/sysconfig/networkfor some instances that require zeroconf to be disabled. Removing these customizations would prevent the instance to come up. So leave the customizations in/etc/sysconfig/networkintact except those that we are interested in.Fixes GH-5990
Signed-off-by: Ani Sinha anisinha@redhat.com
Merge type