This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Implement Saml integration #21
Merged
javierdelapuente
merged 8 commits into
main
from
ISD-1984-Implement-SAML-integration-for-Paas-App-Charmer
Jun 10, 2024
Merged
Implement Saml integration #21
javierdelapuente
merged 8 commits into
main
from
ISD-1984-Implement-SAML-integration-for-Paas-App-Charmer
Jun 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturo-seijas
previously approved these changes
Jun 7, 2024
cbartz
previously approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1412556
jdkandersson
approved these changes
Jun 10, 2024
Test coverage for e0e5f0b
Static code analysis report
|
arturo-seijas
approved these changes
Jun 10, 2024
cbartz
approved these changes
Jun 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec: ISD140
Overview
This PR adds Saml support to
paas-app-charmer
using thesaml-integrator
charm.All the following env variables will be available to the
paas-app-charmer
workload if Saml is integrated correctly with apaas-app-charmer
generated project:These variables contain enough information about the IdP for the SP, so projects (or frameworks) based on libraries like
python3-saml
andpysaml2
could easily use Saml with those env variables.An integration test that generates the env variables from the
saml-integration
has been written. However, no real Saml authentication has been done in this test, as that would introduce extra complexity to the test that will test a Saml library, not the injection of the env variables.Rationale
Saml is a widely used standard for authentication/authorization, and
paas-app-charmer
apps can benefit from it.Juju Events Changes
Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)