Skip to content

Commit 4482ebe

Browse files
authored
Merge pull request #73 from canopas/ui-fixing
Changed URL for policy and some minor UI changes
2 parents 8712a9d + c140fb5 commit 4482ebe

File tree

6 files changed

+23
-10
lines changed

6 files changed

+23
-10
lines changed

app/src/main/java/com/canopas/yourspace/ui/component/OtpTextField.kt

-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import androidx.compose.runtime.Composable
2020
import androidx.compose.runtime.LaunchedEffect
2121
import androidx.compose.runtime.remember
2222
import androidx.compose.ui.Alignment
23-
import androidx.compose.ui.ExperimentalComposeUiApi
2423
import androidx.compose.ui.Modifier
2524
import androidx.compose.ui.focus.FocusRequester
2625
import androidx.compose.ui.focus.focusRequester
@@ -75,7 +74,6 @@ fun OtpInputField(
7574
}
7675
}
7776

78-
@OptIn(ExperimentalComposeUiApi::class)
7977
@Composable
8078
private fun OTPDigit(
8179
index: Int,

app/src/main/java/com/canopas/yourspace/ui/flow/home/space/create/SpaceInviteCodeScreen.kt

+6-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ import androidx.compose.foundation.layout.fillMaxSize
99
import androidx.compose.foundation.layout.fillMaxWidth
1010
import androidx.compose.foundation.layout.height
1111
import androidx.compose.foundation.layout.padding
12+
import androidx.compose.foundation.rememberScrollState
1213
import androidx.compose.foundation.shape.RoundedCornerShape
14+
import androidx.compose.foundation.verticalScroll
1315
import androidx.compose.material3.ExperimentalMaterial3Api
1416
import androidx.compose.material3.Icon
1517
import androidx.compose.material3.IconButton
@@ -67,6 +69,7 @@ private fun SpaceInviteContent(modifier: Modifier) {
6769
Column(
6870
modifier
6971
.fillMaxSize()
72+
.verticalScroll(rememberScrollState())
7073
.background(AppTheme.colorScheme.surface)
7174
.padding(horizontal = 16.dp, vertical = 24.dp),
7275
horizontalAlignment = Alignment.CenterHorizontally
@@ -93,7 +96,9 @@ private fun SpaceInviteContent(modifier: Modifier) {
9396
Spacer(modifier = Modifier.weight(1f))
9497

9598
PrimaryButton(
96-
modifier = Modifier.fillMaxWidth(),
99+
modifier = Modifier
100+
.fillMaxWidth()
101+
.padding(top = 16.dp),
97102
label = stringResource(R.string.onboard_share_space_code_btn),
98103
onClick = { shareInvitationCode(context, viewModel.spaceInviteCode) }
99104
)

app/src/main/java/com/canopas/yourspace/ui/flow/home/space/join/JoinSpaceScreen.kt

+8-2
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@ package com.canopas.yourspace.ui.flow.home.space.join
22

33
import androidx.compose.foundation.layout.Column
44
import androidx.compose.foundation.layout.Spacer
5+
import androidx.compose.foundation.layout.fillMaxSize
56
import androidx.compose.foundation.layout.fillMaxWidth
67
import androidx.compose.foundation.layout.height
78
import androidx.compose.foundation.layout.padding
9+
import androidx.compose.foundation.rememberScrollState
10+
import androidx.compose.foundation.verticalScroll
811
import androidx.compose.material3.AlertDialog
912
import androidx.compose.material3.Button
1013
import androidx.compose.material3.ExperimentalMaterial3Api
@@ -65,7 +68,8 @@ private fun JoinSpaceContent(modifier: Modifier) {
6568
val state by viewModel.state.collectAsState()
6669
Column(
6770
modifier
68-
.fillMaxWidth()
71+
.fillMaxSize()
72+
.verticalScroll(rememberScrollState())
6973
.padding(16.dp),
7074
horizontalAlignment = Alignment.CenterHorizontally
7175
) {
@@ -85,7 +89,9 @@ private fun JoinSpaceContent(modifier: Modifier) {
8589
text = stringResource(R.string.onboard_space_join_subtitle),
8690
style = AppTheme.appTypography.subTitle1.copy(color = AppTheme.colorScheme.textDisabled),
8791
textAlign = TextAlign.Center,
88-
modifier = Modifier.fillMaxWidth()
92+
modifier = Modifier
93+
.fillMaxWidth()
94+
.padding(bottom = 8.dp)
8995
)
9096
Spacer(modifier = Modifier.weight(1f))
9197
PrimaryButton(

app/src/main/java/com/canopas/yourspace/ui/flow/journey/components/LocationHistory.kt

+5-1
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@ import androidx.compose.foundation.layout.fillMaxSize
1414
import androidx.compose.foundation.layout.height
1515
import androidx.compose.foundation.layout.padding
1616
import androidx.compose.foundation.layout.size
17+
import androidx.compose.foundation.rememberScrollState
1718
import androidx.compose.foundation.shape.CircleShape
1819
import androidx.compose.foundation.shape.RoundedCornerShape
20+
import androidx.compose.foundation.verticalScroll
1921
import androidx.compose.material.icons.Icons
2022
import androidx.compose.material.icons.filled.LocationOn
2123
import androidx.compose.material3.Button
@@ -277,7 +279,9 @@ fun DottedTimeline(isSteadyLocation: Boolean, isLastItem: Boolean) {
277279
@Composable
278280
fun EmptyHistory() {
279281
Column(
280-
modifier = Modifier.fillMaxSize(),
282+
modifier = Modifier
283+
.fillMaxSize()
284+
.verticalScroll(rememberScrollState()),
281285
horizontalAlignment = Alignment.CenterHorizontally,
282286
verticalArrangement = Arrangement.Center
283287
) {

app/src/main/java/com/canopas/yourspace/ui/flow/settings/SettingsScreen.kt

+3-3
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ private fun SettingsContent(modifier: Modifier) {
114114
ProfileView(user = it) { viewModel.editProfile() }
115115
HorizontalDivider(
116116
modifier = Modifier
117-
.padding(bottom = 24.dp)
117+
.padding(bottom = 20.dp)
118118
.fillMaxWidth(),
119119
color = AppTheme.colorScheme.outline
120120
)
@@ -152,7 +152,7 @@ private fun OtherSettingsContent(viewModel: SettingsViewModel) {
152152
textAlign = TextAlign.Start,
153153
modifier = Modifier
154154
.fillMaxWidth()
155-
.padding(start = 16.dp)
155+
.padding(start = 16.dp, top = 16.dp)
156156
)
157157

158158
SettingsItem(
@@ -204,7 +204,7 @@ private fun SpaceSettingsContent(
204204
Row(
205205
modifier = Modifier
206206
.fillMaxWidth()
207-
.padding(bottom = 24.dp)
207+
.padding(bottom = 12.dp)
208208
) {
209209
Text(
210210
text = stringResource(id = R.string.setting_spaces),

data/src/main/java/com/canopas/yourspace/data/utils/Config.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package com.canopas.yourspace.data.utils
22

33
object Config {
44

5-
const val PRIVACY_POLICY_URL = "https://canopas.github.io/your-space/"
5+
const val PRIVACY_POLICY_URL = "https://canopas.github.io/your-space-android/"
66

77
const val FIRESTORE_COLLECTION_USERS = "users"
88
const val FIRESTORE_COLLECTION_USER_SESSIONS = "user_sessions"

0 commit comments

Comments
 (0)