Fb/service test (#74)

* make cds service work without failed http calls in no_redis mode

* make integration tests use common config

* basic tests for cds-service

* upgrade lock

* update snaps

* stop console time logs

Author: rlindner81

Diff for: jest.setupAfterEnv.js

@@ -5,5 +5,6 @@ jest.spyOn(console, "log").mockImplementation();
 jest.spyOn(console, "info").mockImplementation();
 jest.spyOn(console, "warn").mockImplementation();
 jest.spyOn(console, "error").mockImplementation();
+jest.spyOn(console, "time").mockImplementation();
 jest.spyOn(process.stdout, "write").mockImplementation();
 jest.spyOn(process.stderr, "write").mockImplementation();

Diff for: package-lock.json

@@ -34,6 +34,7 @@
   },
   "devDependencies": {
     "@sap/cds": "^8.2.3",
+    "axios": "^1.7.7",
     "eslint": "^8.57.1",
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-jest": "^28.8.3",

Diff for: package.json

@@ -920,7 +920,7 @@ class FeatureToggles {
   async getRemoteFeaturesInfos() {
     this._ensureInitialized();
     if ((await redis.getIntegrationMode()) === REDIS_INTEGRATION_MODE.NO_REDIS) {
-      return null;
+      return {};
     }
 
     const remoteStateScopedValues = await redis.hashGetAllObjects(this.__redisKey);

Diff for: src/featureToggles.js

@@ -41,7 +41,7 @@ const mockConfig = {
   [FEATURE.E]: {
     fallbackValue: 5,
     type: "number",
-    validations: [{ regex: "^\\d{1}$" }],
+    validations: [{ scopes: ["component", "layer", "tenant"] }, { regex: "^\\d{1}$" }],
   },
   [FEATURE.F]: {
     fallbackValue: "best",

Diff for: test/__common__/mockdata.js

@@ -85,6 +85,13 @@ exports[`feature toggles test basic apis getFeaturesInfos 1`] = `
       "SOURCE": "RUNTIME",
       "TYPE": "number",
       "VALIDATIONS": [
+        {
+          "scopes": [
+            "component",
+            "layer",
+            "tenant",
+          ],
+        },
         {
           "regex": "^\\d{1}$",
         },
@@ -194,13 +201,25 @@ exports[`feature toggles test basic apis initializeFeatureToggles 1`] = `
     "SOURCE": "RUNTIME",
     "TYPE": "number",
     "VALIDATIONS": [
+      {
+        "scopes": [
+          "component",
+          "layer",
+          "tenant",
+        ],
+      },
       {
         "regex": "^\\d{1}$",
       },
     ],
     "VALIDATIONS_REGEX": [
       /\\^\\\\d\\{1\\}\\$/,
     ],
+    "VALIDATIONS_SCOPES_MAP": {
+      "component": true,
+      "layer": true,
+      "tenant": true,
+    },
   },
   "test/feature_f": {
     "SOURCE": "RUNTIME",

Diff for: test/__snapshots__/featureToggles.test.js.snap

@@ -0,0 +1,101 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`cds-service endpoints state response 1`] = `
+{
+  "test/feature_a": {
+    "config": {
+      "SOURCE": "RUNTIME",
+      "TYPE": "boolean",
+    },
+    "fallbackValue": false,
+  },
+  "test/feature_aa": {
+    "config": {
+      "SOURCE": "RUNTIME",
+      "TYPE": "boolean",
+      "VALIDATIONS": [
+        {
+          "scopes": [
+            "tenant",
+            "user",
+          ],
+        },
+      ],
+    },
+    "fallbackValue": false,
+  },
+  "test/feature_b": {
+    "config": {
+      "SOURCE": "RUNTIME",
+      "TYPE": "number",
+    },
+    "fallbackValue": 1,
+  },
+  "test/feature_c": {
+    "config": {
+      "SOURCE": "RUNTIME",
+      "TYPE": "string",
+    },
+    "fallbackValue": "best",
+  },
+  "test/feature_d": {
+    "config": {
+      "SOURCE": "RUNTIME",
+      "TYPE": "boolean",
+      "VALIDATIONS": [
+        {
+          "regex": "^(?:true)$",
+        },
+      ],
+    },
+    "fallbackValue": true,
+  },
+  "test/feature_e": {
+    "config": {
+      "SOURCE": "RUNTIME",
+      "TYPE": "number",
+      "VALIDATIONS": [
+        {
+          "scopes": [
+            "component",
+            "layer",
+            "tenant",
+          ],
+        },
+        {
+          "regex": "^\\d{1}$",
+        },
+      ],
+    },
+    "fallbackValue": 5,
+  },
+  "test/feature_f": {
+    "config": {
+      "SOURCE": "RUNTIME",
+      "TYPE": "string",
+      "VALIDATIONS": [
+        {
+          "regex": "^(?:best|worst)$",
+        },
+      ],
+    },
+    "fallbackValue": "best",
+  },
+  "test/feature_g": {
+    "config": {
+      "ACTIVE": false,
+      "SOURCE": "RUNTIME",
+      "TYPE": "string",
+    },
+    "fallbackValue": "activeTest",
+  },
+  "test/feature_h": {
+    "config": {
+      "APP_URL": "\\.cfapps\\.sap\\.hana\\.ondemand\\.com$",
+      "SOURCE": "RUNTIME",
+      "TYPE": "string",
+    },
+    "fallbackValue": "appUrlTest",
+  },
+}
+`;