Skip to content

Commit e218bc2

Browse files
committed
fix: fix switch case for inline loading not working
switch case compares the value in the case via === which does not work with || or &&
1 parent 691d3c3 commit e218bc2

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/inline-loading/inline-loading.component.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,27 +34,27 @@ export enum InlineLoadingState {
3434
template: `
3535
@if (state !== InlineLoadingState.Hidden) {
3636
<div class="cds--inline-loading__animation">
37-
@switch (state) {
38-
@case (InlineLoadingState.Inactive || InlineLoadingState.Active) {
37+
@switch (true) {
38+
@case (state === InlineLoadingState.Inactive || state === InlineLoadingState.Active) {
3939
<div
4040
class="cds--loading cds--loading--small"
4141
[ngClass]="{
42-
'cds--loading--stop': state === InlineLoadingState.Inactive
42+
'cds--loading--stop': state === InlineLoadingState.Inctive
4343
}">
4444
<svg class="cds--loading__svg" viewBox="0 0 100 100">
4545
<circle class="cds--loading__background" cx="50%" cy="50%" r="44" />
4646
<circle class="cds--loading__stroke" cx="50%" cy="50%" r="44" />
4747
</svg>
4848
</div>
4949
}
50-
@case (InlineLoadingState.Finished) {
50+
@case (state === InlineLoadingState.Finished) {
5151
<svg
5252
cdsIcon="checkmark--filled"
5353
size="16"
5454
class="cds--inline-loading__checkmark-container">
5555
</svg>
5656
}
57-
@case (InlineLoadingState.Error) {
57+
@case (state === InlineLoadingState.Error) {
5858
<svg
5959
cdsIcon="error--filled"
6060
size="16"
@@ -64,14 +64,14 @@ export enum InlineLoadingState {
6464
}
6565
</div>
6666
}
67-
@switch(state) {
68-
@case(InlineLoadingState.Inactive || InlineLoadingState.Active) {
67+
@switch(true) {
68+
@case(state === InlineLoadingState.Inactive || state === InlineLoadingState.Active) {
6969
<p class="cds--inline-loading__text">{{loadingText}}</p>
7070
}
71-
@case(InlineLoadingState.Finished) {
71+
@case(state === InlineLoadingState.Finished) {
7272
<p class="cds--inline-loading__text">{{successText}}</p>
7373
}
74-
@case(InlineLoadingState.Error) {
74+
@case(state === InlineLoadingState.Error) {
7575
<p class="cds--inline-loading__text">{{errorText}}</p>
7676
}
7777
}

0 commit comments

Comments
 (0)