Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code block] Evaluate the background color #4436

Open
thyhmdo opened this issue Jan 22, 2025 · 0 comments
Open

[Code block] Evaluate the background color #4436

thyhmdo opened this issue Jan 22, 2025 · 0 comments

Comments

@thyhmdo
Copy link
Member

thyhmdo commented Jan 22, 2025

Problem

Currently, our website is on the Gray 10 background, so it should have a white layering token. The code blocks are in darker gray (examples below). This was probably because we had pulled the code block and code snippets inconsistently from Gatsby and Carbon.


Action

Evaluate if we need to update this or if it should be fine because it depends on the different use cases. If it's pulled from Carbon, it also has the copy feature which might not be necessary when we document keyboard interactions.


Here are a few other examples

Image

Image

Image


An example that could correct the issue if we want these code blocks to follow the layering logic:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Later 🧊
Development

No branches or pull requests

1 participant