Add a diagnostic note for errors during identifying facet types #6445
+443
−253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The first new commit here is |
danakj
force-pushed
the
diagnostic-note-identifying
branch
from
d96ee28 to
fd0ada4
Compare
danakj
force-pushed
the
diagnostic-note-identifying
branch
from
fd0ada4 to
6f6edf8
Compare
geoffromer
reviewed
Dec 1, 2025
| // CHECK:STDERR: fail_error_in_identifying_extend_require_facet_type.carbon:[[@LINE+6]]:37: error: array bound of -1 is negative [ArrayBoundNegative] | ||
| // CHECK:STDERR: extend require impls K(array(i32, N)); | ||
| // CHECK:STDERR: ^ | ||
| // CHECK:STDERR: fail_error_in_identifying_extend_require_facet_type.carbon:[[@LINE+3]]:3: note: in `require` used here [ResolvingSpecificHere] |
Contributor
There was a problem hiding this comment.
In this test the locations of the ResolvingSpecificHere notes contain the locations of the errors they annotate. Will that be true in general? If not, is it feasible to have a test where that's not the case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors that occur while constructing a specific should be tied back to the facet type being identified. We don't have an InstId for the facet type during identify, so provide the means to Stringify a FacetTypeId.
Depends on #6435