Accept longer re-enqueueing and add known issue

Author: ch1bo

docs/docs/known-issues.md

@@ -57,6 +57,10 @@ Note that, as with any adjustments of this kind, it is good practice to make a b
 
 There is a hard-coded limit on the **mainnet** where only up to 100 ada can be committed into the Hydra head. This is a safety precaution and will be increased as more experience is gained in running Hydra heads on the mainnet.
 
+### Deposit period must match
+
+The `--deposit-period` allows an individual `hydra-node` operator to decide how long they want a deposit to have settled at least. However, differences bigger than [`defaultTTL * waitDelay`](https://hydra.family/head-protocol/haddock/hydra-node/Hydra-Node.html#v:waitDelay) (currently 10 minutes) result in non-approved snapshots. This is due to the way the `HeadLogic` is implemented and snapshot requests are not retried currently. See [hydra#1999](https://github.com/cardano-scaling/hydra/issues/1999) for more context.
+
 ### Known bugs
 
 Refer to the project repository issue tracker for [known issues](https://github.com/cardano-scaling/hydra/issues?q=is%3Aissue+is%3Aopen+label%3A%22bug+%3Abug%3A%22). If you discover any security-relevant problems, please follow our [security policy](https://github.com/cardano-scaling/hydra?tab=security-ov-file#readme).

hydra-node/src/Hydra/HeadLogic.hs

@@ -101,9 +101,6 @@ import Hydra.Tx.OnChainId (OnChainId)
 import Hydra.Tx.Party (Party (vkey))
 import Hydra.Tx.Snapshot (ConfirmedSnapshot (..), Snapshot (..), SnapshotNumber, SnapshotVersion, getSnapshot)
 
-defaultTTL :: TTL
-defaultTTL = 10000
-
 onConnectionEvent :: Network.Connectivity -> Outcome tx
 onConnectionEvent = \case
   Network.NetworkConnected ->

hydra-node/src/Hydra/Node.hs

@@ -311,11 +311,11 @@ stepHydraNode node = do
 
 -- | The maximum number of times to re-enqueue a 'Wait' outcome.
 defaultTTL :: TTL
-defaultTTL = 10000
+defaultTTL = 6000
 
--- | The time to wait between re-enqueuing a 'Wait' outcome
+-- | The time to wait between re-enqueuing a 'Wait' outcome.
 waitDelay :: DiffTime
-waitDelay = 1
+waitDelay = 0.1
 
 -- | Monadic interface around 'Hydra.Logic.update'.
 processNextInput ::

hydra-node/test/Hydra/BehaviorSpec.hs

@@ -35,14 +35,14 @@ import Hydra.Chain (
 import Hydra.Chain.ChainState (ChainSlot (ChainSlot), ChainStateType, IsChainState, chainStateSlot)
 import Hydra.Chain.Direct.Handlers (getLatest, newLocalChainState, pushNew, rollback)
 import Hydra.Events (EventSink (..))
-import Hydra.HeadLogic (CoordinatedHeadState (..), Effect (..), HeadState (..), IdleState (..), InitialState (..), Input (..), OpenState (..), defaultTTL)
+import Hydra.HeadLogic (CoordinatedHeadState (..), Effect (..), HeadState (..), IdleState (..), InitialState (..), Input (..), OpenState (..))
 import Hydra.HeadLogicSpec (testSnapshot)
 import Hydra.Ledger (Ledger, nextChainSlot)
 import Hydra.Ledger.Simple (SimpleChainState (..), SimpleTx (..), aValidTx, simpleLedger, utxoRef, utxoRefs)
 import Hydra.Logging (Tracer)
 import Hydra.Network (Network (..))
 import Hydra.Network.Message (Message, NetworkEvent (..))
-import Hydra.Node (DraftHydraNode (..), HydraNode (..), HydraNodeLog (..), connect, createNodeState, queryHeadState, runHydraNode, waitDelay)
+import Hydra.Node (DraftHydraNode (..), HydraNode (..), HydraNodeLog (..), connect, createNodeState, defaultTTL, queryHeadState, runHydraNode, waitDelay)
 import Hydra.Node.DepositPeriod (DepositPeriod (..))
 import Hydra.Node.DepositPeriod qualified as DP
 import Hydra.Node.Environment (Environment (..))

hydra-node/test/Hydra/HeadLogicSpec.hs

@@ -46,7 +46,6 @@ import Hydra.HeadLogic (
   WaitReason (..),
   aggregateState,
   cause,
-  defaultTTL,
   update,
  )
 import Hydra.HeadLogic.State (SeenSnapshot (..), getHeadParameters)
@@ -56,6 +55,7 @@ import Hydra.Ledger.Cardano.TimeSpec (genUTCTime)
 import Hydra.Ledger.Simple (SimpleChainState (..), SimpleTx (..), aValidTx, simpleLedger, utxoRef, utxoRefs)
 import Hydra.Network (Connectivity)
 import Hydra.Network.Message (Message (..), NetworkEvent (..))
+import Hydra.Node (defaultTTL)
 import Hydra.Node.Environment (Environment (..))
 import Hydra.Options (defaultContestationPeriod, defaultDepositPeriod)
 import Hydra.Prelude qualified as Prelude

hydra-node/test/Hydra/Model/MockChain.hs

@@ -63,7 +63,6 @@ import Hydra.HeadLogic (
   InitialState (..),
   Input (..),
   OpenState (..),
-  defaultTTL,
  )
 import Hydra.Ledger (Ledger (..), ValidationError (..), collectTransactions)
 import Hydra.Ledger.Cardano (adjustUTxO, fromChainSlot)
@@ -72,7 +71,7 @@ import Hydra.Logging (Tracer)
 import Hydra.Model.Payment (CardanoSigningKey (..))
 import Hydra.Network (Network (..))
 import Hydra.Network.Message (Message, NetworkEvent (..))
-import Hydra.Node (DraftHydraNode (..), HydraNode (..), NodeState (..), connect)
+import Hydra.Node (DraftHydraNode (..), HydraNode (..), NodeState (..), connect, defaultTTL)
 import Hydra.Node.Environment (Environment (Environment, participants, party))
 import Hydra.Node.InputQueue (InputQueue (..))
 import Hydra.NodeSpec (mockServer)