refactor: replace local isPrivateProperty with the implementation in eslint-etc

Author: NachoVazquez

package.json

@@ -6,7 +6,7 @@
   "dependencies": {
     "@typescript-eslint/experimental-utils": "^5.0.0",
     "common-tags": "^1.8.0",
-    "eslint-etc": "^5.0.0",
+    "eslint-etc": "^5.2.0",
     "requireindex": "~1.2.0",
     "tslib": "^2.0.0"
   },

source/rules/prefer-composition.ts

@@ -11,10 +11,11 @@ import {
   isAssignmentExpression,
   isCallExpression,
   isIdentifier,
+  isPrivateIdentifier,
   isMemberExpression,
   isVariableDeclarator,
 } from "eslint-etc";
-import { ruleCreator, isPrivateIdentifier } from "../utils";
+import { ruleCreator } from "../utils";
 
 const defaultOptions: readonly {
   checkDecorators?: string[];

source/utils.ts

@@ -4,16 +4,8 @@
  */
 
 import { ESLintUtils } from "@typescript-eslint/experimental-utils";
-import { TSESTree as es } from "@typescript-eslint/experimental-utils";
 
 export const ruleCreator = ESLintUtils.RuleCreator(
   (name) =>
     `https://github.com/cartant/eslint-plugin-rxjs-angular/tree/main/docs/rules/${name}.md`
 );
-
-// TODO: Remove when eslint-etc supports isPrivateIdentifier
-export function isPrivateIdentifier(
-  node: es.Node
-): node is es.PrivateIdentifier {
-  return node.type === "PrivateIdentifier";
-}

yarn.lock

@@ -699,7 +699,7 @@ [email protected], escape-string-regexp@^4.0.0:
   resolved "https://registry.yarnpkg.com/escape-string-regexp/-/escape-string-regexp-4.0.0.tgz#14ba83a5d373e3d311e5afca29cf5bfad965bf34"
   integrity sha512-TtpcNJ3XAzx3Gq8sWRzJaVajRs0uVxA2YAkdb1jm2YkPz4G6egUFAyA3n5vtEIZefPk5Wa4UXbKuS5fKkJWdgA==
 
-eslint-etc@^5.0.0:
+eslint-etc@^5.2.0:
   version "5.2.0"
   resolved "https://registry.yarnpkg.com/eslint-etc/-/eslint-etc-5.2.0.tgz#c51c19a2ffb6447af76a1c5ffd13b9a212db859b"
   integrity sha512-Gcm/NMa349FOXb1PEEfNMMyIANuorIc2/mI5Vfu1zENNsz+FBVhF62uY6gPUCigm/xDOc8JOnl+71WGnlzlDag==