Remove private property tests (sebastianbergmann/phpunit#3339)

Signed-off-by: andyo <[email protected]>

Author: javabudd

test/Query/Provider/DefaultOdmFactoryTest.php

@@ -19,18 +19,17 @@ class DefaultOdmFactoryTest extends TestCase
 {
     use ProphecyTrait;
 
-    public function testInvokableFactoryReturnsDefaultOdmQueryProvider()
+    public function testInvokableFactoryReturnsDefaultOdmQueryProvider(): void
     {
         $serviceLocator = $this->prophesize(ServiceLocatorInterface::class)->reveal();
 
         $factory = new DefaultOdmFactory();
         $provider = $factory($serviceLocator);
 
         $this->assertInstanceOf(DefaultOdm::class, $provider);
-        $this->assertAttributeSame($serviceLocator, 'serviceLocator', $provider);
     }
 
-    public function testInvokableFactoryReturnsDefaultOdmQueryProviderWhenCreatedViaAbstractPluginManager()
+    public function testInvokableFactoryReturnsDefaultOdmQueryProviderWhenCreatedViaAbstractPluginManager(): void
     {
         $serviceLocator = $this->prophesize(ServiceLocatorInterface::class)->reveal();
         $abstractPluginManager = $this->prophesize(AbstractPluginManager::class);
@@ -40,6 +39,5 @@ public function testInvokableFactoryReturnsDefaultOdmQueryProviderWhenCreatedVia
         $provider = $factory($abstractPluginManager->reveal());
 
         $this->assertInstanceOf(DefaultOdm::class, $provider);
-        $this->assertAttributeSame($serviceLocator, 'serviceLocator', $provider);
     }
 }

test/Query/Provider/DefaultOrmFactoryTest.php

@@ -19,18 +19,17 @@ class DefaultOrmFactoryTest extends TestCase
 {
     use ProphecyTrait;
 
-    public function testInvokableFactoryReturnsDefaultOrmQueryProvider()
+    public function testInvokableFactoryReturnsDefaultOrmQueryProvider(): void
     {
         $serviceLocator = $this->prophesize(ServiceLocatorInterface::class)->reveal();
 
         $factory = new DefaultOrmFactory();
         $provider = $factory($serviceLocator);
 
         $this->assertInstanceOf(DefaultOrm::class, $provider);
-        $this->assertAttributeSame($serviceLocator, 'serviceLocator', $provider);
     }
 
-    public function testInvokableFactoryReturnsDefaultOrmQueryProviderWhenCreatedViaAbstractPluginManager()
+    public function testInvokableFactoryReturnsDefaultOrmQueryProviderWhenCreatedViaAbstractPluginManager(): void
     {
         $serviceLocator = $this->prophesize(ServiceLocatorInterface::class)->reveal();
         $abstractPluginManager = $this->prophesize(AbstractPluginManager::class);
@@ -40,6 +39,5 @@ public function testInvokableFactoryReturnsDefaultOrmQueryProviderWhenCreatedVia
         $provider = $factory($abstractPluginManager->reveal());
 
         $this->assertInstanceOf(DefaultOrm::class, $provider);
-        $this->assertAttributeSame($serviceLocator, 'serviceLocator', $provider);
     }
 }