Fabric turtle/pocket upgrades registration in 1.19.4

[SirEdvin]

For forge turtle upgrades registration is fairly straightforward. However, when it comes to fabric, how do I suppose to register turtle upgrades?

I, obviously, need access to created registries, because created my own will not help (fabric in general mostly about registry extending that creating it own), but for now code doesn't store them anywhere and I am forced to retrieve them dynamically.

And very strange thing about this, that this code:

println(RegistriesAccessor.getROOT().keySet())
val turtleSerializerRegister = RegistriesAccessor.getROOT().get(TurtleUpgradeSerialiser.REGISTRY_ID.location()) as Registry<TurtleUpgradeSerialiser<*>>
val pocketSerializerRegister = RegistriesAccessor.getROOT().get(PocketUpgradeSerialiser.REGISTRY_ID.location()) as Registry<PocketUpgradeSerialiser<*>>

works, but this

val turtleSerializerRegister = RegistriesAccessor.getROOT().get(TurtleUpgradeSerialiser.REGISTRY_ID.location()) as Registry<TurtleUpgradeSerialiser<*>>
val pocketSerializerRegister = RegistriesAccessor.getROOT().get(PocketUpgradeSerialiser.REGISTRY_ID.location()) as Registry<PocketUpgradeSerialiser<*>>

Throws NullPointerException, because RegistriesAccessor.getROOT().get(TurtleUpgradeSerialiser.REGISTRY_ID.location()) returns null instead of proper register (even if computercraft init was called first).

PS: And of course, this behavior inconsistent!

[SirEdvin]

Okey, I have answer now. You should use RegistryEntryAddedCallback event to resolve this issue.

So, when you trying to access registries and they are not available, you should register callback for RegistryEntryAddedCallback, but if registries are available, you must register with them, because you will not have any RegistryEntryAddedCallback event for them.

[SquidDev]

Not answering your question, but can you not use BuiltInRegistries.REGISTRY.get(TurtleUpgradeSerialiser.REGISTRY_ID.location()); instead of RegistriesAccessor.getROOT() (which I'm assuming is an accessor mixin)? That's what I do here:

CC-Tweaked/projects/fabric/src/main/java/dan200/computercraft/shared/platform/PlatformHelperImpl.java

Lines 90 to 95 in 3bf2969

	@SuppressWarnings("unchecked")
	private static <T> Registry<T> getRegistry(ResourceKey<Registry<T>> id) {
	var registry = (Registry<T>) BuiltInRegistries.REGISTRY.get(id.location());
	if (registry == null) throw new IllegalArgumentException("Unknown registry " + id);
	return registry;
	}

[SirEdvin]

Yes, I also should do this, thanks!

[SirEdvin]

Okey, code still goes out of control with this problem

PeripheralWorksPlatform.registerTurtleUpgrade(
            PeripheraliumHubPeripheral.ID,

            TurtleUpgradeSerialiser.simpleWithCustomItem {_, stack ->
                return@simpleWithCustomItem PeripheraliumHubTurtleUpgrade(PeripheralWorksConfig.peripheraliumHubUpgradeCount, stack)
            }, { dataProvider, serializer ->
                dataProvider.simpleWithCustomItem(
                    PeripheraliumHubPeripheral.ID,
                    serializer, Items.PERIPHERALIUM_HUB.get()
                )
            },
            listOf(Consumer{
                PeripheralWorksClientCore.registerHook { ComputerCraftAPIClient.registerTurtleUpgradeModeller(
                    it.get(), TurtleUpgradeModeller.flatItem()
                ) }
            })
        )

@SquidDev can we have some special API for fabric for registration update in registries or just this registries exposed directly?