Skip to content

Commit b691ab1

Browse files
committed
unit test tidy up
1 parent 31d41e7 commit b691ab1

File tree

4 files changed

+8
-9
lines changed

4 files changed

+8
-9
lines changed

s3-angular-website/typescript/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
"buildwebsite": "cd website && npm i && npm run build && cd ../",
77
"buildcdk": "cd cdk && npm i && npm run build && cd ../",
88
"build": "npm run buildwebsite && npm run buildcdk",
9-
"deploy": "npm run build && cd cdk && npm run deploy"
9+
"deploy": "npm run build && cd cdk && npm run deploy",
10+
"test": "echo \"no ci/cd tests setup\""
1011
},
1112
"author": "",
1213
"license": "ISC"

s3-react-website/typescript/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
"buildwebsite": "cd website && npm i && npm run build && cd ../",
77
"buildcdk": "cd cdk && npm i && npm run build && cd ../",
88
"build": "npm run buildwebsite && npm run buildcdk",
9-
"deploy": "npm run build && cd cdk && npm run deploy"
9+
"deploy": "npm run build && cd cdk && npm run deploy",
10+
"test": "echo \"no ci/cd tests setup\""
1011
},
1112
"author": "",
1213
"license": "ISC"

the-cloudwatch-dashboard/typescript/lib/the-cloudwatch-dashboard-stack.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ export class TheCloudwatchDashboardStack extends cdk.Stack {
106106
label: 'DynamoDB Errors',
107107
usingMetrics: {
108108
m1: table.metricUserErrors(),
109-
m2: table.metricSystemErrors(),
109+
m2: table.metricSystemErrorsForOperations(),
110110
},
111111
period: cdk.Duration.minutes(5)
112112
});

the-cloudwatch-dashboard/typescript/test/the-cloudwatch-dashboard.test.ts

+3-6
Original file line numberDiff line numberDiff line change
@@ -278,13 +278,10 @@ test('DynamoDB Errors Alarm Created', () => {
278278
}
279279
},
280280
{
281+
"Expression": "getitem + batchgetitem + scan + query + getrecords + putitem + deleteitem + updateitem + batchwriteitem",
281282
"Id": "m2",
282-
"MetricStat": {
283-
"Metric": {
284-
"MetricName": "SystemErrors",
285-
"Namespace": "AWS/DynamoDB"
286-
}
287-
}
283+
"Label": "Sum of errors across all operations",
284+
"ReturnData": false
288285
}],
289286
"Threshold": 0
290287
}

0 commit comments

Comments
 (0)