Skip to content

Update transferId assignment logic in BridgeTransferLib #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xriptide wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update transferId assignment logic in BridgeTransferLib #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions contracts/libraries/BridgeTransferLib.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,18 +364,22 @@ library BridgeTransferLib {
) internal returns (ReceiveInfo memory) {
ReceiveInfo memory recv;
PbPegged.Withdraw memory request = PbPegged.decWithdraw(_request);
if (IOriginalTokenVaultV2(_bridgeAddr).records(request.refId)) {
recv.transferId = keccak256(
abi.encodePacked(
request.receiver,
request.token,
request.amount,
request.burnAccount,
request.refChainId,
request.refId,
_bridgeAddr
)
);

// Compute the exact withdrawId (wdId) used by OriginalTokenVaultV2
bytes32 wdId = keccak256(
abi.encodePacked(
request.receiver,
request.token,
request.amount,
request.burnAccount,
request.refChainId,
request.refId,
_bridgeAddr
)
);

if (IOriginalTokenVaultV2(_bridgeAddr).records(wdId)) {
recv.transferId = wdId;
} else {
recv.transferId = IOriginalTokenVaultV2(_bridgeAddr).withdraw(_request, _sigs, _signers, _powers);
}
Expand Down