This repository has been archived by the owner on Dec 7, 2018. It is now read-only.
Raise ECONNRESET if socket#gets returns nil #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows ruby driver approach. Fix for celluloid#4
Infrastructure for testing against a new redis instance.
|
You almost had it ;) Looks like ddb853a breaks the build on JRuby |
|
Latest commit fixes that on jruby 1.7.3. The problem was in the test helper which spawns a new instance of redis to test against. Which introduced its own timing issues. Think the latest version is more solid. Though not yet sure if this is the best way to test things like shutdown. |
tarcieri
added a commit
that referenced
this pull request
Mar 31, 2013
Raise ECONNRESET if socket#gets returns nil
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows ruby driver approach. Fixes #4