spike(release): draft for e2e tests #1130
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…submit step before signing and certifying --> submitting
I'm really happy with where we are with our Playwright tests, so let's get rid of the cypress tests to prevent those failures from letting us have those sweet green check marks. ✅ Currently the cypress tests fail when running on commits on main due to [a missing record key](https://github.com/cfpb/sbl-frontend/actions/runs/12263581708/job/34215508209). We don't need these tests anymore, and I think now is the time to get rid of them. <img width="1234" alt="Screenshot 2024-12-10 at 2 24 59 PM" src="https://github.com/user-attachments/assets/db4ac511-17d4-4223-a6fb-24b12c04fac5"> Closes #992 - Removes cypress from deps, readme, package.json scripts, cache, and removes the folder of test files 1. Does the website still build and work? <img width="1109" alt="Screenshot 2024-12-10 at 2 22 04 PM" src="https://github.com/user-attachments/assets/822aeaf6-e47e-46e0-8f01-748399b2a424">
Closes #1040 ## Changes - Updated Dockerfile to use new `ghcr.io/cfpb/regtech/sbl/node-js-alpine:3.20` (node 22) base image. - Updated `package.json -> engines` to use Node v22 - Updated `.nvmrc` to use `v22` ## How to test this PR 1. Pull branch 2. `nvm use` 3. `yarn start` to easily launch all backend services 4. `yarn docker-build-and-run` to run the container version of the Frontend 5. Update your `.env` file to run tests against the container version ``` SBL_PLAYWRIGHT_TEST_TARGET="http://localhost:8085" ``` 6. `yarn playwright test --workers 4` 7. Verify all tests pass
Fixes e2e tests and bumps deps: Bumps the npm_and_yarn group with 5 updates: Updates axios from 1.7.4 to 1.7.5 Updates vite from 4.5.3 to 4.5.5 Updates micromatch from 4.0.5 to 4.0.8 Updates path-to-regexp from 6.2.1 to 6.3.0 Updates rollup from 2.79.1 to 2.79.2
## Changes - forces resolution to cross-spawn 7.0.5 ## How to test this PR 1. Do all the tests pass?  3. How does the site behave after the dep bump?   --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- update axios to 1.8.2 - update vite to 4.5.6 - update vite-plugin-pwa to 0.20.5 to update subdep rollup 1. Do all the tests pass?  3. Does the website function normally?  
billhimmelsbach
force-pushed
the
release-mar-13-2025
branch
from
763b23c to
2b694d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft release for e2e tests