Skip to content

Commit 9088aff

Browse files
authored
fix: use package name for package_name resolution (#1215)
1 parent fe55d14 commit 9088aff

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

swiftpkg/internal/swiftpkg_build_files.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def _swift_target_build_file(pkg_ctx, target):
6161

6262
# Gate package_name behind swift tools version 5.9
6363
if tools_version_major >= 6 or (tools_version_major == 5 and tools_version_minor >= 9):
64-
attrs["package_name"] = target.label.repository_name.lstrip("@") + ".rspm"
64+
attrs["package_name"] = pkg_ctx.pkg_info.name
6565

6666
target_deps = []
6767
macro_targets = []

swiftpkg/tests/swiftpkg_build_files_tests.bzl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ swift_library(
494494
always_include_developer_search_paths = True,
495495
copts = ["-DSWIFT_PACKAGE"],
496496
module_name = "RegularSwiftTargetAsLibrary",
497-
package_name = "swiftpkg_mypackage.rspm",
497+
package_name = "MyPackage",
498498
srcs = ["Source/RegularSwiftTargetAsLibrary/RegularSwiftTargetAsLibrary.swift"],
499499
tags = ["manual"],
500500
visibility = ["//:__subpackages__"],
@@ -516,7 +516,7 @@ swift_library(
516516
copts = ["-DSWIFT_PACKAGE"],
517517
deps = ["@swiftpkg_mypackage//:RegularSwiftTargetAsLibrary.rspm"],
518518
module_name = "RegularTargetForExec",
519-
package_name = "swiftpkg_mypackage.rspm",
519+
package_name = "MyPackage",
520520
srcs = ["Source/RegularTargetForExec/main.swift"],
521521
tags = ["manual"],
522522
visibility = ["//:__subpackages__"],
@@ -534,7 +534,7 @@ swift_test(
534534
copts = ["-DSWIFT_PACKAGE"],
535535
deps = ["@swiftpkg_mypackage//:RegularSwiftTargetAsLibrary.rspm"],
536536
module_name = "RegularSwiftTargetAsLibraryTests",
537-
package_name = "swiftpkg_mypackage.rspm",
537+
package_name = "MyPackage",
538538
srcs = ["Tests/RegularSwiftTargetAsLibraryTests/RegularSwiftTargetAsLibraryTests.swift"],
539539
visibility = ["//:__subpackages__"],
540540
)
@@ -561,7 +561,7 @@ swift_binary(
561561
"//conditions:default": [],
562562
}),
563563
module_name = "SwiftExecutableTarget",
564-
package_name = "swiftpkg_mypackage.rspm",
564+
package_name = "MyPackage",
565565
srcs = ["Source/SwiftExecutableTarget/main.swift"],
566566
visibility = ["//:__subpackages__"],
567567
)
@@ -737,7 +737,7 @@ swift_library(
737737
"//conditions:default": [],
738738
}),
739739
module_name = "SwiftLibraryWithConditionalDep",
740-
package_name = "swiftpkg_mypackage.rspm",
740+
package_name = "MyPackage",
741741
srcs = ["Source/SwiftLibraryWithConditionalDep/SwiftLibraryWithConditionalDep.swift"],
742742
tags = ["manual"],
743743
visibility = ["//:__subpackages__"],
@@ -807,7 +807,7 @@ swift_library(
807807
],
808808
generates_header = True,
809809
module_name = "SwiftForObjcTarget",
810-
package_name = "swiftpkg_mypackage.rspm",
810+
package_name = "MyPackage",
811811
srcs = ["Source/SwiftForObjcTarget/SwiftForObjcTarget.swift"],
812812
tags = ["manual"],
813813
visibility = ["//:__subpackages__"],
@@ -846,7 +846,7 @@ swift_library(
846846
copts = ["-DSWIFT_PACKAGE"],
847847
data = [":SwiftLibraryWithFilePathResource.rspm_resource_bundle"],
848848
module_name = "SwiftLibraryWithFilePathResource",
849-
package_name = "swiftpkg_mypackage.rspm",
849+
package_name = "MyPackage",
850850
srcs = [
851851
"Source/SwiftLibraryWithFilePathResource/SwiftLibraryWithFilePathResource.swift",
852852
":SwiftLibraryWithFilePathResource.rspm_resource_bundle_accessor",

0 commit comments

Comments
 (0)