fix: use SAL2 _In_, _Out_ to prevent conflicts (#7042)

Codebase cleanup (Updating old SAL annotations to SAL2, fixing a pointer cast to remove a warning)
Updating CI for new Ubuntu versions.

Author: ShortDevelopment

azure-pipelines.yml

@@ -33,32 +33,32 @@ jobs:
       maxParallel: 6
       matrix:
         Linux.Debug:
-          image_name: 'ubuntu-22.04'
+          image_name: 'ubuntu-24.04'
           deps: 'sudo apt-get install -y ninja-build clang libicu-dev'
           build_type: 'Debug'
           libtype_flag: ''
         Linux.NoJit:
-          image_name: 'ubuntu-22.04'
+          image_name: 'ubuntu-24.04'
           deps: 'sudo apt-get install -y ninja-build clang libicu-dev'
           build_type: 'Debug'
           libtype_flag: '-DDISABLE_JIT=ON'
         Linux.ReleaseWithDebug:
-          image_name: 'ubuntu-22.04'
+          image_name: 'ubuntu-24.04'
           deps: 'sudo apt-get install -y ninja-build clang libicu-dev'
           build_type: 'RelWithDebInfo'
           libtype_flag: ''
         Linux.Release:
-          image_name: 'ubuntu-22.04'
+          image_name: 'ubuntu-24.04'
           deps: 'sudo apt-get install -y ninja-build clang libicu-dev'
           build_type: 'Release'
           libtype_flag: ''
-        Ubuntu20.ReleaseWithDebug:
-          image_name: 'ubuntu-20.04'
+        Ubuntu22.ReleaseWithDebug:
+          image_name: 'ubuntu-22.04'
           deps: 'sudo apt-get install -y ninja-build clang libicu-dev'
           build_type: 'RelWithDebInfo'
           libtype_flag: ''
-        Ubuntu20.Release:
-          image_name: 'ubuntu-20.04'
+        Ubuntu22.Release:
+          image_name: 'ubuntu-22.04'
           deps: 'sudo apt-get install -y ninja-build clang libicu-dev'
           build_type: 'Release'
           libtype_flag: ''

bin/ChakraCore/ChakraCoreDllFunc.cpp

@@ -1,5 +1,6 @@
 //-------------------------------------------------------------------------------------------------------
 // Copyright (C) Microsoft. All rights reserved.
+// Copyright (c) ChakraCore Project Contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
 #include "Runtime.h"
@@ -174,7 +175,7 @@ void ChakraBinaryAutoSystemInfoInit(AutoSystemInfo * autoSystemInfo)
 
 #if !ENABLE_NATIVE_CODEGEN
 HRESULT JsInitializeJITServer(
-    __in GUID* connectionUuid,
+    _In_ GUID* connectionUuid,
     __in_opt void* securityDescriptor,
     __in_opt void* alpcSecurityDescriptor)
 {

bin/ChakraCore/ConfigParserExternals.cpp

@@ -1,16 +1,17 @@
 //-------------------------------------------------------------------------------------------------------
 // Copyright (C) Microsoft. All rights reserved.
+// Copyright (c) ChakraCore Project Contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
 #include "Common.h"
 #include "Core/ConfigParser.h"
 
-bool ConfigParserAPI::FillConsoleTitle(__ecount(cchBufferSize) LPWSTR buffer, size_t cchBufferSize, __in LPWSTR moduleName)
+bool ConfigParserAPI::FillConsoleTitle(__ecount(cchBufferSize) LPWSTR buffer, size_t cchBufferSize, _In_ LPWSTR moduleName)
 {
     return false;
 }
 
-void ConfigParserAPI::DisplayInitialOutput(__in LPWSTR moduleName)
+void ConfigParserAPI::DisplayInitialOutput(_In_ LPWSTR moduleName)
 {
 }
 

bin/ChakraCore/TestHooks.cpp

@@ -1,5 +1,6 @@
 //-------------------------------------------------------------------------------------------------------
 // Copyright (C) Microsoft. All rights reserved.
+// Copyright (c) ChakraCore Project Contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
 #include "Runtime.h"
@@ -28,7 +29,7 @@ namespace Js
 
 #ifdef ENABLE_TEST_HOOKS
 
-HRESULT __stdcall SetConfigFlags(__in int argc, __in_ecount(argc) LPWSTR argv[], ICustomConfigFlags* customConfigFlags)
+HRESULT __stdcall SetConfigFlags(_In_ int argc, __in_ecount(argc) LPWSTR argv[], ICustomConfigFlags* customConfigFlags)
 {
     CmdLineArgsParser parser(customConfigFlags);
     if (parser.Parse(argc, argv) != 0)
@@ -39,7 +40,7 @@ HRESULT __stdcall SetConfigFlags(__in int argc, __in_ecount(argc) LPWSTR argv[],
     return S_OK;
 }
 
-HRESULT __stdcall SetConfigFile(__in LPWSTR strConfigFile)
+HRESULT __stdcall SetConfigFile(_In_ LPWSTR strConfigFile)
 {
     CmdLineArgsParser parser;
     ConfigParser::ParseCustomConfigFile(parser, strConfigFile);

bin/GCStress/GCStress.h

@@ -1,5 +1,6 @@
 //-------------------------------------------------------------------------------------------------------
 // Copyright (C) Microsoft. All rights reserved.
+// Copyright (c) ChakraCore Project Contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
 #pragma once
@@ -148,7 +149,7 @@ class Location
                     VerifyCondition(found);
 
                     // Zero pointers in order to eliminate false-positives
-                    memset(holder, 0, heapObject.GetSize());
+                    memset((void*)holder, 0, heapObject.GetSize());
 
                     bool success = heapObject.ClearImplicitRootBit();
                     VerifyCondition(success);

bin/GCStress/StubExternalApi.cpp

@@ -1,20 +1,21 @@
 //-------------------------------------------------------------------------------------------------------
 // Copyright (C) Microsoft. All rights reserved.
+// Copyright (c) ChakraCore Project Contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
 #include "Common.h"
 #include "CommonInl.h" // TODO: Try to remove this later
 
 #include "Core/ConfigParser.h"
 
-bool ConfigParserAPI::FillConsoleTitle(__ecount(cchBufferSize) LPWSTR buffer, size_t cchBufferSize, __in LPWSTR moduleName)
+bool ConfigParserAPI::FillConsoleTitle(__ecount(cchBufferSize) LPWSTR buffer, size_t cchBufferSize, _In_ LPWSTR moduleName)
 {
     swprintf_s(buffer, cchBufferSize, _u("Chakra GC: %lu - %s"), GetCurrentProcessId(), moduleName);
 
     return true;
 }
 
-void ConfigParserAPI::DisplayInitialOutput(__in LPWSTR moduleName)
+void ConfigParserAPI::DisplayInitialOutput(_In_ LPWSTR moduleName)
 {
     Output::Print(_u("Chakra GC\n"));
     Output::Print(_u("INIT: PID        : %d\n"), GetCurrentProcessId());

bin/NativeTests/BigUIntTest.h

@@ -1,5 +1,6 @@
 //-------------------------------------------------------------------------------------------------------
 // Copyright (C) Microsoft. All rights reserved.
+// Copyright (c) ChakraCore Project Contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
 
@@ -17,7 +18,7 @@ namespace Js
         Assert(false);
     }
 
-    bool Throw::ReportAssert(__in char const *, unsigned int, __in char const *, __in char const *)
+    bool Throw::ReportAssert(_In_ char const *, unsigned int, _In_ char const *, _In_ char const *)
     {
         return false;
     }

bin/ch/ChakraRtInterface.h

@@ -1,6 +1,6 @@
 //-------------------------------------------------------------------------------------------------------
 // Copyright (C) Microsoft. All rights reserved.
-// Copyright (c) 2021 ChakraCore Project Contributors. All rights reserved.
+// Copyright (c) ChakraCore Project Contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
 #pragma once
@@ -342,8 +342,8 @@ class ChakraRTInterface
     static void UnloadChakraDll(HINSTANCE library);
 
     static HRESULT SetAssertToConsoleFlag(bool flag) { return CHECKED_CALL(SetAssertToConsoleFlag, flag); }
-    static HRESULT SetConfigFlags(__in int argc, __in_ecount(argc) LPWSTR argv[], ICustomConfigFlags* customConfigFlags) { return CHECKED_CALL(SetConfigFlags, argc, argv, customConfigFlags); }
-    static HRESULT SetConfigFile(__in LPWSTR strConfigFileName) { return CHECKED_CALL(SetConfigFile, strConfigFileName); }
+    static HRESULT SetConfigFlags(_In_ int argc, __in_ecount(argc) LPWSTR argv[], ICustomConfigFlags* customConfigFlags) { return CHECKED_CALL(SetConfigFlags, argc, argv, customConfigFlags); }
+    static HRESULT SetConfigFile(_In_ LPWSTR strConfigFileName) { return CHECKED_CALL(SetConfigFile, strConfigFileName); }
     static HRESULT GetFileNameFlag(BSTR * filename) { return CHECKED_CALL(GetFilenameFlag, filename); }
     static HRESULT PrintConfigFlagsUsageString() { m_usageStringPrinted = true;  return CHECKED_CALL(PrintConfigFlagsUsageString); }
 

bin/ch/Helpers.cpp

@@ -1,5 +1,6 @@
 //-------------------------------------------------------------------------------------------------------
 // Copyright (C) Microsoft. All rights reserved.
+// Copyright (c) ChakraCore Project Contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
 #include "stdafx.h"
@@ -423,7 +424,7 @@ LPCWSTR Helpers::JsErrorCodeToString(JsErrorCode jsErrorCode)
     }
 }
 
-void Helpers::LogError(__in __nullterminated const char16 *msg, ...)
+void Helpers::LogError(_In_ __nullterminated const char16 *msg, ...)
 {
     va_list args;
     va_start(args, msg);

bin/ch/Helpers.h

@@ -1,5 +1,6 @@
 //-------------------------------------------------------------------------------------------------------
 // Copyright (C) Microsoft. All rights reserved.
+// Copyright (c) ChakraCore Project Contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
 //-------------------------------------------------------------------------------------------------------
 #pragma once
@@ -9,7 +10,7 @@ class Helpers
 public :
     static HRESULT LoadScriptFromFile(LPCSTR filename, LPCSTR& contents, UINT* lengthBytesOut = nullptr, std::string* fullPath = nullptr, bool shouldMute = false);
     static LPCWSTR JsErrorCodeToString(JsErrorCode jsErrorCode);
-    static void LogError(__in __nullterminated const char16 *msg, ...);
+    static void LogError(_In_ __nullterminated const char16 *msg, ...);
     static HRESULT LoadBinaryFile(LPCSTR filename, LPCSTR& contents, UINT& lengthBytes, bool printFileOpenError = true);
 
     static void TTReportLastIOErrorAsNeeded(BOOL ok, const char* msg);