Proposal: drop rimraf and lint-staged as part of e18e cleanup? #3552
Closed
Adebesin-Cell
started this conversation in
General
Replies: 2 comments
-
|
Sounds good to me. Feel free to open a PR for this |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Opened #3555 for this. Covers both:
On the Also worth noting, (Transitive |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Not a hard proposal, more taking the temperature of the community on this one 🙂
As part of the broader e18e effort (reducing install size / dropping packages that now have native or lighter equivalents), I noticed Panda still pulls in a couple of dev dependencies that have well-trodden replacements. Wanted to lay out where they're used and the tradeoffs.
rimrafUsed in a few scripts:
clean→pnpm -r --parallel exec rimraf dist .turbo *.logreset→pnpm -r --parallel exec rimraf node_modules && rimraf node_modulessandbox/next-js-{app,pages}dev→rimraf .next && next deve18e suggests native
fs.rm({ recursive: true, force: true }), available since Node 14.14.The single-path cases (
.next,node_modules) are easy to swap. The one that needs thought isclean, it passes multiple paths and a glob (*.log), andfs.rmdoesn't handle globs or multiple args. So that one would either need a small helper script or to keep leaning on shell expansion. Curious whether folks think the win is worth that bit of friction, or whether it's cleaner to just leavecleanas-is.lint-staged.husky/pre-commitrunslint-stagedwith a single config entry. e18e suggestsnano-staged, same package.json config shape, much smaller.The caveat is
nano-stageddrops the more advanced bits (stash/partial-staging, per-dir monorepo configs). Panda's current config looks simple enough that this shouldn't matter, but flagging it in case there's history I'm missing.Question
Worth doing? Mostly want to check there's no reason these were chosen deliberately before anyone spends time on it.
Beta Was this translation helpful? Give feedback.
All reactions