You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 0450ccb
Browse filesBrowse the repository at this point in the historyBrowse files
Address review: deadline, environment and version resolution
Fixes found reviewing the multi-query settings resolvers.
- resolveDeadline dropped the client-level timeout as soon as any one query
set its own. A query that sets no timeout is bounded by the client-level
timeout, so that is its effective timeout and it has to take part in the
maximum; otherwise a client built with a 5m timeout batching a 1s query
alongside an unset one deadlined the whole request at 1s, killing a query
that would have had 5m on its own. This contradicted the method's own
stated invariant. A query that is effectively unbounded now yields no
deadline at all.
- resolveEnvironment compared raw per-query values, so naming the client's
own environment on one query and leaving it unset on another was reported
as a conflict even though both resolve to the same environment. It now
compares the effective value, as resolveBranch already did.
- Dropped the queryNameVersion agreement requirement. The justification
does not hold for the version: there is no x-chalk-query-name-version
header, and each sub-request carries its own version in its
OnlineQueryContext, so queries differing only by version are satisfiable.
- unmarshal() NPE'd on a null scalars table, which is exactly what a
sub-query that failed to execute leaves behind, so the documented empty
slot made the README's own pattern fail with an opaque error. It now
explains where to find the reason.
- Guard the varargs overload against a null array so it reports the same
ClientException as the List overload rather than a raw NPE, and drop a
repeated format argument that made the count-mismatch message
tautological.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
0 commit comments