Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate in favour of node:util stripVTControlCharacters? #53

Open
SBoudrias opened this issue Jan 13, 2025 · 3 comments
Open

Deprecate in favour of node:util stripVTControlCharacters? #53

SBoudrias opened this issue Jan 13, 2025 · 3 comments

Comments

@SBoudrias
Copy link

Hi, now that Node has stripVTControlCharacters in the core, is there a good reason to keep using strip-ansi? (Fully supported since Node v16.11.0)

I hope this doesn't come across the wrong way! I used strip-ansi a long time and I'm thankful for it ❤️

  • Is there things strip-ansi does that's not in stripVTControlCharacters?
  • If not, for the ecosystem health, maybe you could consider adding a note on the README?
@gnify
Copy link

gnify commented Jan 14, 2025

Hey again :D

Coming from SBoudrias/Inquirer.js#1643

Node.js’s implementation of stripVTControlCharacters is based on the code from this package (see this line). From what I can tell, it’s basically this package with some internal Node.js stuff added

@sindresorhus
Copy link
Member

We should definitely mention stripVTControlCharacters in the readme.

This packages does have some benefits though. It gets improvements faster and it also provides consistent behavior across Node.js versions.

So it doesn't make sense to deprecate the package.

@gnify
Copy link

gnify commented Jan 14, 2025

We should definitely mention stripVTControlCharacters in the readme.

This packages does have some benefits though. It gets improvements faster and it also provides consistent behavior across Node.js versions.

So it doesn't make sense to deprecate the package.

First of all, thank you for your incredible contributions to open source! If it weren’t for your work and packages like this, this conversation might not even be happening. Your efforts truly shape the ecosystem, and we all deeply appreciate it. ❤️

Regarding the package's future, what do you think about adding a note to the README that the package is in a "finished" state? It would continue to receive maintenance and support, but no new features would be added. This with the mention of possibly considering stripVTControlCharacters/ or maybe README could contain some insights on Node's implementation and why people should prefer one or another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants