Add knip (#104)

Author: marcalexiei

.github/workflows/ci.yml

@@ -47,7 +47,10 @@ jobs:
         run: yarn format:check
 
       - name: Run lint
-        run: yarn lint:ci
+        run: yarn lint:js:ci
+
+      - name: Run knip
+        run: yarn lint:knip
 
       - name: Run typecheck
         run: yarn typecheck

.oxlintrc.jsonc

@@ -21,6 +21,7 @@
     "no-warning-comments": "off",
     "sort-keys": "off",
 
+    "vitest/no-conditional-in-test": "off",
     "jest/no-conditional-in-test": "off",
 
     "typescript/array-type": ["error", { "default": "generic", "readonly": "generic" }],

package.json

@@ -8,18 +8,23 @@
   "scripts": {
     "format": "oxfmt",
     "format:check": "oxfmt --check",
-    "lint": "oxlint",
-    "lint:fix": "oxlint --fix",
-    "lint:ci": "oxlint --format=github",
+    "lint": "yarn lint:js && yarn lint:knip",
+    "lint:js": "oxlint",
+    "lint:js:fix": "oxlint --fix",
+    "lint:js:ci": "oxlint --format=github",
+    "lint:knip": "knip",
     "typecheck": "tsc --noEmit",
     "test": "vitest"
   },
   "dependencies": {
     "@changesets/assemble-release-plan": "^6.0.2",
     "@changesets/config": "^3.0.1",
+    "@changesets/errors": "^0.2.0",
     "@changesets/parse": "^0.4.0",
     "@changesets/types": "^6.0.0",
     "@manypkg/get-packages": "^1.1.3",
+    "@octokit/webhooks": "^9.8.4",
+    "@sentry/node": "^6.0.0",
     "@types/js-yaml": "^3.12.2",
     "@types/markdown-table": "^2.0.0",
     "@types/micromatch": "^4.0.1",
@@ -30,15 +35,16 @@
     "human-id": "^1.0.2",
     "js-yaml": "^3.14.0",
     "markdown-table": "^2.0.0",
+    "micromatch": "^4.0.2",
     "next": "^12.1.6",
     "node-fetch": "^2.6.1",
-    "path": "^0.12.7",
     "probot": "^12.2.4",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
     "typescript": "^6.0.2"
   },
   "devDependencies": {
+    "knip": "^6.11.0",
     "msw": "^2.12.14",
     "oxfmt": "^0.42.0",
     "oxlint": "^1.58.0",

test/index.test.ts

@@ -284,7 +284,6 @@ describe.concurrent("changeset-bot", () => {
     } as never);
 
     const commentRequests = requests.filter(
-      // oxlint-disable-next-line vitest/no-conditional-in-test
       (request) => request.path.includes("/comments") && request.method === "PATCH",
     );