-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CurvedSegment Ribs are too small and don't fit the hullcurve #34
Comments
5% was a guesstimate. here are the boundingboxes:
in this case the ribs are too short by 1.5mm for a diameter of 100mm - or 1.5% |
when not using a hullcurve, the size is correct - so the issue doesn't seem to be the shape interpolation of the ribs (which is trivial in this case) but the scaling to the hullcurve(s) |
found the issue. scaleByBoundbox() computes the scale factor based on relative sizes of the bounding boxes. The bounding box of the hullcurve is calculated correctly. However the bounding box of the to be rescaled shape - in case of the CurvedArray is taken from the base shape - which is almost always correct (unless the base shape has been created by script) The following workaround fixes the issue:
|
Thank you for your contribution to fix this |
The CurvedSegment tool creates ribs that are too small, they do not fill the hullcurve.
In the attached document, the beginning and end shape is identical (a circle) - the ribs in between are interpolated once with CurvedArray using only one reference shape, and once with CurvedSegment using both, in both cases using the same single hullcurve (which is just a straight line/box)
while the curved array ribs completely fill the hullcurve (green), the curved segment ribs are about 5% too short (red)
wrongshape.zip


The text was updated successfully, but these errors were encountered: