Move appsignal calls to instrumentation

Author: svanhesteren

lib/gouda.rb

@@ -70,6 +70,11 @@ def self.logger
     Gouda.config.logger
   end
 
+  def self.instrument(channel, **options, &block)
+    ActiveSupport::Notifications.instrument("#{channel}.gouda", **options, &block)
+  end
+
+
   def self.create_tables(active_record_schema)
     active_record_schema.create_enum :gouda_workload_state, %w[enqueued executing finished]
     active_record_schema.create_table :gouda_workloads, id: :uuid do |t|

lib/gouda/worker.rb

@@ -163,7 +163,8 @@ def self.worker_loop(n_threads:, check_shutdown: TrapShutdownCheck.new, queue_co
         # Find jobs which just hung and clean them up (mark them as "finished" and enqueue replacement workloads if possible)
         Gouda::Workload.reap_zombie_workloads
       rescue => e
-        Appsignal.add_exception(e)
+        Gouda.instrument(:exception, exception: e)
+
         warn "Uncaught exception during housekeeping (#{e.class} - #{e}"
       end
 

lib/gouda/workload.rb

@@ -63,7 +63,7 @@ def self.reap_zombie_workloads
           workload.with_lock("FOR UPDATE SKIP LOCKED") do
             Gouda.logger.info { "Reviving (re-enqueueing) Gouda workload #{workload.id} after interruption" }
 
-            Appsignal.increment_counter("gouda_workloads_revived", 1, job_class: workload.active_job_class_name)
+            Gouda.instrument(:workloads_revived_counter, size: 1, job_class: workload.active_job_class_name)
 
             interrupted_at = workload.last_execution_heartbeat_at
             workload.update!(state: "finished", interrupted_at: interrupted_at, last_execution_heartbeat_at: Time.now.utc, execution_finished_at: Time.now.utc)