Skip to content

Commit 970e5e5

Browse files
Fix tests.
1 parent 0e95c5b commit 970e5e5

File tree

2 files changed

+18
-14
lines changed

2 files changed

+18
-14
lines changed

test/helpers.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from unittest.mock import MagicMock
1111

1212
from db_wrapper.connection import ConnectionParameters
13-
from db_wrapper.client import Client
13+
from db_wrapper.client import AsyncClient
1414

1515

1616
def composed_to_string(seq: Iterable[Any]) -> str:
@@ -25,6 +25,7 @@ def composed_to_string(seq: Iterable[Any]) -> str:
2525

2626
class AsyncMock(MagicMock):
2727
"""Extend unittest.mock.MagicMock to allow mocking of async functions."""
28+
2829
# pylint: disable=invalid-overridden-method
2930
# pylint: disable=useless-super-delegation
3031

@@ -42,7 +43,7 @@ def wrapped(instance: Any) -> None:
4243
return wrapped
4344

4445

45-
def get_client() -> Client:
46+
def get_client() -> AsyncClient:
4647
"""Create a client with placeholder connection data."""
47-
conn_params = ConnectionParameters('a', 'a', 'a', 'a', 'a')
48-
return Client(conn_params)
48+
conn_params = ConnectionParameters('a', 1, 'a', 'a', 'a')
49+
return AsyncClient(conn_params)

test/test_model.py

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,24 @@
2020

2121
import helpers
2222

23-
from db_wrapper.client import Client
23+
from db_wrapper.client import AsyncClient
2424
from db_wrapper.model import (
25-
Model,
2625
ModelData,
27-
Read,
26+
AsyncModel,
27+
AsyncRead
28+
)
29+
from db_wrapper.model.base import (
2830
UnexpectedMultipleResults,
29-
NoResultFound)
31+
NoResultFound,
32+
)
3033

3134

3235
# Generic doesn't need a more descriptive name
3336
# pylint: disable=invalid-name
3437
T = TypeVar('T', bound=ModelData)
3538

3639

37-
def setup(query_result: List[T]) -> Tuple[Model[T], Client]:
40+
def setup(query_result: List[T]) -> Tuple[AsyncModel[T], AsyncClient]:
3841
"""Setup helper that returns instances of both a Model & a Client.
3942
4043
Mocks the execute_and_return method on the Client instance to skip
@@ -53,7 +56,7 @@ def setup(query_result: List[T]) -> Tuple[Model[T], Client]:
5356
return_value=query_result)
5457

5558
# init model with mocked client
56-
model = Model[Any](client, 'test')
59+
model = AsyncModel[Any](client, 'test')
5760

5861
return model, client
5962

@@ -92,7 +95,7 @@ async def test_it_raises_exception_if_more_than_one_result(self) -> None:
9295

9396
@ helpers.async_test
9497
async def test_it_raises_exception_if_no_result_to_return(self) -> None:
95-
model: Model[ModelData]
98+
model: AsyncModel[ModelData]
9699
model, _ = setup([])
97100

98101
with self.assertRaises(NoResultFound):
@@ -231,16 +234,16 @@ async def test_it_returns_the_deleted_record(self) -> None:
231234

232235
class TestExtendingModel(TestCase):
233236
"""Testing Model's extensibility."""
234-
model: Model[ModelData]
237+
model: AsyncModel[ModelData]
235238

236239
def setUp(self) -> None:
237-
class ReadExtended(Read[ModelData]):
240+
class ReadExtended(AsyncRead[ModelData]):
238241
"""Extending Read with additional query."""
239242

240243
def new_query(self) -> None:
241244
pass
242245

243-
model = Model[ModelData](helpers.get_client(), 'test')
246+
model = AsyncModel[ModelData](helpers.get_client(), 'test')
244247
model.read = ReadExtended(model.client, model.table)
245248

246249
self.model = model

0 commit comments

Comments
 (0)