Skip to content

Incompatibility with Static.jl v1 is causing package resolution problems #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
korsbo opened this issue Feb 3, 2025 · 5 comments
Closed
Assignees

Comments

@korsbo
Copy link

korsbo commented Feb 3, 2025

Hi, as mentioned in #32, the incompatibility of this package with Static.jl v1 is causing some package resolution problems for certain applications. I see from the failing CI of #32 that it's not sufficient with a trivial bump of the compat list but I have not looked deep enough to understand the extent of the update required.

@chengchingwen chengchingwen self-assigned this Feb 8, 2025
@chengchingwen
Copy link
Owner

It seems Static.jl v1 is not relevant to the failing CI which failed to infer the return type of some rrule, so I merged it directly. I'll try if I can find the correct cause that silently messes up the type inference, if not, I will disable those checks and make a release these days.

@chengchingwen
Copy link
Owner

The CI fail is caused by ChainRulesCore.jl v1.25.1 (see JuliaDiff/ChainRulesCore.jl#684).

@korsbo
Copy link
Author

korsbo commented Feb 19, 2025

Thanks for looking into this! My particular problem seems to be resolved on master.

@johannes-fischer
Copy link
Contributor

Could you tag and register a new version? Currently it still doesn't work if you just ]add Transformers to a workspace that requires Static.jl v1.0, since the merged change is not in a registered version of this package. So it still requires to add NeuralAttentionlib#master.

@chengchingwen
Copy link
Owner

tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants