Skip to content

8.1.1: Deprecated: Optional parameter $after declared before required parameter $value #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RobertEcker opened this issue Dec 28, 2021 · 2 comments

Comments

@RobertEcker
Copy link

Deprecated: Optional parameter $after declared before required parameter $value is implicitly treated as a required parameter in C:\wamp\www\vendor\cheprasov\php-redis-client\src\RedisClient\Command\Traits\Version2x6\ListsCommandsTrait.php on line 94
public function linsert($key, $after = true, $pivot, $value) {
remove "= true"

PHP 8.1.1
php-redis-client: latest version

ethanhann added a commit to ethanhann/php-redis-client that referenced this issue Jun 4, 2022
This is more just a quick fix to resolve issue cheprasov#81. Really, $after should be at the end of the argument list (as $pivot and $value should always have arguments) or $after shouldn't have a default value, but both of those changes would break backward compatibility.
@mxdpeep
Copy link

mxdpeep commented Aug 6, 2022

Deprecated: Optional parameter $after declared before required parameter $value is implicitly treated as a required parameter in C:\wamp\www\vendor\cheprasov\php-redis-client\src\RedisClient\Command\Traits\Version2x6\ListsCommandsTrait.php on line 94 public function linsert($key, $after = true, $pivot, $value) { remove "= true"

PHP 8.1.1 php-redis-client: latest version

it seems the code is unmaintained

@mxdpeep
Copy link

mxdpeep commented Aug 7, 2022

Hi Fred,

Thanks a lot.
Yep, unfortunately, I have not time anymore for free maintenance open source project. Sorry.
Please feel free to use another libraries for using redis.

Regards,
Alexander

so we need to clone the repo and maintain it on our own 😒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants