🚿 AccessToken: remove unnecessary public setExpiry()

Author: codemasher

src/Core/AccessToken.php

@@ -86,17 +86,10 @@ final class AccessToken extends SettingsContainerAbstract{
 	 */
 	protected string|null $provider = null;
 
-	/**
-	 * Expiry setter
-	 */
-	protected function set_expires(DateTime|DateInterval|int|null $expires = null):void{
-		$this->setExpiry($expires);
-	}
-
 	/**
 	 * Sets the expiration for this token, clamps the expiry to EXPIRY_MAX
 	 */
-	public function setExpiry(DateTime|DateInterval|int|null $expires = null):AccessToken{
+	protected function set_expires(DateTime|DateInterval|int|null $expires = null):void{
 		$now = time();
 		$max = ($now + $this::EXPIRY_MAX);
 
@@ -114,7 +107,6 @@ public function setExpiry(DateTime|DateInterval|int|null $expires = null):Access
 			$this->expires = $max;
 		}
 
-		return $this;
 	}
 
 	/**

tests/Core/AccessTokenTest.php

@@ -91,31 +91,31 @@ public static function isExpiredDataProvider():array{
 	}
 
 	#[DataProvider('isExpiredDataProvider')]
-	public function testIsExpired(int $expires, bool $isExpired):void{
-		$this->token->setExpiry($expires);
+	public function testIsExpired(int $expiry, bool $isExpired):void{
+		$this->token->expires = $expiry;
 		$this::assertSame($isExpired, $this->token->isExpired());
 	}
 
 	#[Group('slow')]
 	public function testIsExpiredVariable():void{
 		$expiry = (time() + 3600);
-		$this->token->setExpiry($expiry);
+		$this->token->expires = $expiry;
 		$this::assertSame($expiry, $this->token->expires);
 		$this::assertFalse($this->token->isExpired());
 
 		$expiry = 3600;
-		$this->token->setExpiry($expiry);
+		$this->token->expires = $expiry;
 		$this::assertSame((time() + $expiry), $this->token->expires);
 		$this::assertFalse($this->token->isExpired());
 
 		$expiry = 2;
-		$this->token->setExpiry($expiry);
+		$this->token->expires = $expiry;
 		$this::assertSame((time() + $expiry), $this->token->expires);
 		sleep(3);
 		$this::assertTrue($this->token->isExpired());
 
 		$expiry = (time() + 2);
-		$this->token->setExpiry($expiry);
+		$this->token->expires = $expiry;
 		$this::assertSame($expiry, $this->token->expires);
 		sleep(3);
 		$this::assertTrue($this->token->isExpired());