Fix bug in index_resources.get_all()

The essential problem is that index_resources.get_all() calls the
Resource get() method which doesn't handle pagination and thus only
returns the first page of results.  The complication is that
index_resources.get_all() builds its own URI complete with filtering.
Thus we call index_resources.get_all() with 'start', 'count' and 'uri'
arguments and remove the 'start' and 'count' fields from the pre-built
uri. The implicated index_resource unit-tests have been updated.

Fixes HewlettPackard#364

Author: eamonnotoole

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 4.7.1
+#### Bug fixes
+- [#364] (https://github.com/HewlettPackard/python-hpOneView/issues/364) Bug in index_resources.get_all()
+
 # 4.7.0
 #### Notes
 Extends support of the SDK to OneView Rest API version 600 (OneView v4.0).

hpOneView/resources/resource.py

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 ###
-# (C) Copyright (2012-2017) Hewlett Packard Enterprise Development LP
+# (C) Copyright (2012-2018) Hewlett Packard Enterprise Development LP
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the "Software"), to deal

hpOneView/resources/search/index_resources.py

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 ###
-# (C) Copyright (2017) Hewlett Packard Enterprise Development LP
+# (C) Copyright (2017-2018) Hewlett Packard Enterprise Development LP
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the "Software"), to deal
@@ -88,25 +88,18 @@ def get_all(self, category='', count=-1, fields='', filter='', padding=0, query=
         uri = self.URI + '?'
 
         uri += self.__list_or_str_to_query(category, 'category')
-        uri += self.__list_or_str_to_query(count, 'count')
         uri += self.__list_or_str_to_query(fields, 'fields')
         uri += self.__list_or_str_to_query(filter, 'filter')
         uri += self.__list_or_str_to_query(padding, 'padding')
         uri += self.__list_or_str_to_query(query, 'query')
         uri += self.__list_or_str_to_query(reference_uri, 'referenceUri')
         uri += self.__list_or_str_to_query(sort, 'sort')
-        uri += self.__list_or_str_to_query(start, 'start')
         uri += self.__list_or_str_to_query(user_query, 'userQuery')
         uri += self.__list_or_str_to_query(view, 'view')
 
         uri = uri.replace('?&', '?')
 
-        response = self._client.get(uri)
-
-        if response and 'members' in response and response['members']:
-            return response['members']
-        else:
-            return []
+        return self._client.get_all(start=start, count=count, uri=uri)
 
     def get(self, uri):
         """

tests/unit/resources/search/test_index_resources.py

@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 ###
-# (C) Copyright (2012-2017) Hewlett Packard Enterprise Development LP
+# (C) Copyright (2012-2018) Hewlett Packard Enterprise Development LP
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the "Software"), to deal
@@ -51,25 +51,24 @@ def setUp(self):
         self.connection = connection(self.host)
         self._resource = IndexResources(self.connection)
 
-    @mock.patch.object(ResourceClient, 'get', return_value=dict(members='test'))
+    @mock.patch.object(ResourceClient, 'get_all', return_value=dict(members='test'))
     def test_get_all_called_once(self, mock_get_all):
         filter = 'name=TestName'
         sort = 'name:ascending'
 
-        expected_uri = '/rest/index/resources?count=500&filter=name=TestName&sort=name:ascending&start=2'
+        expected_uri = '/rest/index/resources?filter=name=TestName&sort=name:ascending'
 
         self._resource.get_all(start=2, count=500, filter=filter, sort=sort)
-        mock_get_all.assert_called_once_with(expected_uri)
+        mock_get_all.assert_called_once_with(start=2, count=500, uri=expected_uri)
 
-    @mock.patch.object(ResourceClient, 'get')
+    @mock.patch.object(ResourceClient, 'get_all')
     def test_get_all_called_once_without_results(self, mock_get_all):
         filter = 'name=TestName'
         sort = 'name:ascending'
 
-        expected_uri = '/rest/index/resources?count=500&filter=name=TestName&sort=name:ascending&start=2'
-
+        expected_uri = '/rest/index/resources?filter=name=TestName&sort=name:ascending'
         self._resource.get_all(start=2, count=500, filter=filter, sort=sort)
-        mock_get_all.assert_called_once_with(expected_uri)
+        mock_get_all.assert_called_once_with(start=2, count=500, uri=expected_uri)
 
     @mock.patch.object(ResourceClient, 'get')
     def test_get_called_once(self, mock_get):