Modify git vcs for testability and add tests.

Author: chrishalbert

src/VCS/AbstractVCS.php

@@ -28,7 +28,7 @@ abstract public function getAuthorAndDate($file, $line);
      * VCSInterface constructor.
      * @param array $entries The uncovered object entries provided by the input.
      */
-    final public function __construct(array $entries = [])
+    public function __construct(array $entries = [])
     {
         $this->setEntries($entries);
     }

src/VCS/GitVCS.php

@@ -22,6 +22,23 @@ class GitVCS extends AbstractVCS
      */
     const DATE = "author-time ";
 
+    /**
+     * The vcs.
+     * @var Git
+     */
+    protected $git;
+
+    /**
+     * GitVCS constructor.
+     * @param array    $entries The entries.
+     * @param Git|null $vcs     The vcs.
+     */
+    public function __construct(array $entries = [], $vcs = null)
+    {
+        $this->git = $vcs ?: new Git();
+        parent::__construct($entries);
+    }
+
     /**
      * Get the author and edit date.
      * @param string  $file The file name.
@@ -30,11 +47,10 @@ class GitVCS extends AbstractVCS
      */
     public function getAuthorAndDate($file, $line)
     {
-        $git = new Git();
         $author = '';
         $date = '';
 
-        $porcelain = $git->blameBus($file, $line);
+        $porcelain = $this->git->blameBus($file, $line);
         foreach ($porcelain as $shard) {
             if (strpos($shard, self::AUTHOR) === 0) {
                 $author = $this->stripEntity(self::AUTHOR, $shard);

tests/src/VCS/GitVCSTest.php

@@ -0,0 +1,118 @@
+<?php
+
+namespace ChrisHalbert\PhpBCC\VCS;
+
+use ChrisHalbert\Git\Git;
+use ChrisHalbert\PhpBCC\Exceptions\InvalidArrayFormatException;
+
+class GitVCSTest extends \PHPUnit_Framework_TestCase
+{
+    protected $git;
+
+    protected $gitVCS;
+
+    public function setUp()
+    {
+        $this->git = $this->getMockBuilder(Git::class)
+            ->setMethods(['blameBus'])
+            ->getMock();
+
+        $this->gitVCS = new GitVCS([], $this->git);
+    }
+
+    public function testGetAuthorAndDate()
+    {
+        $this->setValidMocks();
+        $this->gitVCS->setEntries($this->getEntries());
+        $this->assertEquals($this->getExpectedEntriesWithHistory(), $this->gitVCS->getEntries());
+    }
+
+    /**
+     * @dataProvider dataProviderValidationFails
+     */
+    public function testValidationFails($entries, $expectedException, $exceptionMessage)
+    {
+        $this->setExpectedException($expectedException, $exceptionMessage);
+        $this->gitVCS->setEntries($entries);
+    }
+
+    public function dataProviderValidationFails()
+    {
+        return [
+            [
+                [['1pair' => 1, '2pair' => 2, '3pair' => 3]],
+                InvalidArrayFormatException::class,
+                'Each entry should have only 2 key value pairs.'
+            ],
+            [
+                [['1pair' => 1, '2pair' => 2]],
+                InvalidArrayFormatException::class,
+                'Each entry must have a `file` and a `line` key.'
+            ]
+        ];
+    }
+
+    protected function setValidMocks()
+    {
+        $this->git->expects($this->exactly(2))
+            ->method('blameBus')
+            ->will(
+                $this->onConsecutiveCalls(
+                    [
+                        "a1b2c3d4e5f6",
+                        "author John ",
+                        "author-mail <>",
+                        "author-time 1477980000",
+                        "author-tz -0500",
+                        "committer John ",
+                        "committer-mail <>",
+                        "committer-time 1477980000",
+                        "committer-tz -0500",
+                        "summary Manufacture a test.",
+                        "previous f6e5d4c3d2a1",
+                        "filename src/Foo.php",
+                    ],
+                    [
+                        "a1b2c3d4e5f6",
+                        "author Kelly ",
+                        "author-mail <>",
+                        "author-time 1478066400",
+                        "author-tz -0500",
+                        "committer Kelly ",
+                        "committer-mail <>",
+                        "committer-time 1478066400",
+                        "committer-tz -0500",
+                        "summary Carve out instructions.",
+                        "previous f6e5d4c3d2a1",
+                        "filename src/Foo.php",
+                    ]
+                )
+            );
+    }
+
+    protected function getExpectedEntriesWithHistory()
+    {
+        return [
+            [
+                'author' => 'John', 'date' => '2016-11-01', 'file' => 'Foo.php', 'line' => 1
+            ],
+            [
+                'author' => 'Kelly', 'date' => '2016-11-02', 'file' => 'Bar.php', 'line' => 2
+            ]
+        ];
+    }
+
+    protected function getEntries()
+    {
+        return [
+            [
+                'file' => 'Foo.php',
+                'line' => 1
+            ],
+            [
+                'file' => 'Bar.php',
+                'line' => 2
+            ]
+        ];
+    }
+}