Codec building errors

[tansy]

There are many errors but some are more perplexing than the others.

• Zstd.so is unable to link. It can be done manually but automatically doesn't work.
• Lz5 doesn't work with submodule (it links to lizard). Even checkout of repo from last lz5 commit doesn't work. Only taken from 7-zip-zstd does.
  It works as standalone codec, but in 7z.so it cannot find `ZSTD_XXH32'.

make: Entering directory `/mnt/dev2/src/pak/7zip/p7zip/cielavenir/p7zip-main-gcc/CPP/7zip/Compress/Lz5'
g++ -o b/g_x86/Lz5.so -s -m32 -shared -fPIC -DNDEBUG   -Wl,--no-undefined -Wl,-z,noexecstack b/g_x86/CodecExports.o b/g_x86/DllExportsCompress.o b/g_x86/Alloc.o b/g_x86/Lz5Register.o b/g_x86/Lz5Encoder.o b/g_x86/Lz5Decoder.o b/g_x86/lz5-mt_common.o b/g_x86/lz5-mt_compress.o b/g_x86/lz5-mt_decompress.o b/g_x86/threading.o b/g_x86/lz5.o b/g_x86/lz5hc.o b/g_x86/lz5frame.o b/g_x86/xxhash.o  b/g_x86/MyWindows.o  b/g_x86/InBuffer.o b/g_x86/OutBuffer.o b/g_x86/StreamUtils.o b/g_x86/System.o    -pthread -ldl
b/g_x86/lz5frame.o: In function `LZ5F_decodeHeader':
lz5frame.c:(.text+0x49a): undefined reference to `ZSTD_XXH32'
lz5frame.c:(.text+0x5e6): undefined reference to `ZSTD_XXH32_reset'
b/g_x86/lz5frame.o: In function `LZ5F_compressBegin':
lz5frame.c:(.text+0x9c9): undefined reference to `ZSTD_XXH32_reset'
lz5frame.c:(.text+0xa6e): undefined reference to `ZSTD_XXH32'
b/g_x86/lz5frame.o: In function `LZ5F_compressUpdate':
(...)

• Fast-lzma2 throws strange errors, but when used makefile (cd fast-lzma2 && make) from repository compiles without single warning.
  That's the errors from building codec:

make: Entering directory `/.../p7zip/cielavenir/p7zip-main-gcc/CPP/7zip/Bundles/Format7zF'
gcc -DEXTERNAL_CODECS     -O2 -c -Wall -Wextra -Waddress -Waggressive-loop-optimizations -Wattributes -Wbool-compare -Wcast-align -Wcomment -Wdiv-by-zero -Wduplicated-cond -Wformat-contains-nul -Winit-self -Wint-to-pointer-cast -Wunused   -DNDEBUG -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE  -fPIC -std=c99 -fPIC -o b/g_x86/fl2_compress.o ../../../../Codecs/fast-lzma2/fl2_compress.c -Wno-sign-compare
gcc -DEXTERNAL_CODECS     -O2 -c -Wall -Wextra -Waddress -Waggressive-loop-optimizations -Wattributes -Wbool-compare -Wcast-align -Wcomment -Wdiv-by-zero -Wduplicated-cond -Wformat-contains-nul -Winit-self -Wint-to-pointer-cast -Wunused   -DNDEBUG -D_REENTRANT -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE  -fPIC -std=c99 -fPIC -o b/g_x86/fl2_threading.o ../../../../Codecs/fast-lzma2/fl2_threading.c
In file included from ../../../../Codecs/fast-lzma2/fl2_compress_internal.h:23:0,
                 from ../../../../Codecs/fast-lzma2/fl2_compress.c:19:
../../../../Codecs/fast-lzma2/fl2_threading.h:121:30: warning: ‘struct timespec’ declared inside parameter list will not be visible outside of this definition or declaration
 mythread_condtime_set(struct timespec *condtime, U32 timeout_ms)
                              ^~~~~~~~
../../../../Codecs/fast-lzma2/fl2_threading.h: In function ‘mythread_condtime_set’:
../../../../Codecs/fast-lzma2/fl2_threading.h:123:10: error: dereferencing pointer to incomplete type ‘struct timespec’
  condtime->tv_sec = timeout_ms / 1000;
          ^~
../../../../Codecs/fast-lzma2/fl2_threading.h: In function ‘FL2_pthread_cond_timedwait’:
../../../../Codecs/fast-lzma2/fl2_threading.h:146:21: error: storage size of ‘condtime’ isn’t known
     struct timespec condtime;
                     ^~~~~~~~
../../../../Codecs/fast-lzma2/fl2_threading.h:146:21: warning: unused variable ‘condtime’ [-Wunused-variable]
make: *** [b/g_x86/fl2_compress.o] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory `/.../p7zip/cielavenir/p7zip-main-gcc/CPP/7zip/Bundles/Format7zF'

[cielavenir]

Please check https://github.com/cielavenir/p7zip/blob/main/.github/workflows/ci.yaml and build_linux.sh

Other builders are not supported

[cielavenir]

Lz5 doesn't work with submodule (it links to lizard)

The git repo of Lz5 and Lizard are the same. I think what you need to git submodule update --init --recursive.