From 5ccbf0676b6d790360f5a8a06f6c595759ba1bc5 Mon Sep 17 00:00:00 2001 From: Jussi Maki Date: Thu, 7 Nov 2024 17:21:48 +0100 Subject: [PATCH 1/2] .github: Fix marking PR as failed when test fails The "if: always()" seems to have ignored the earlier step failure and marking even failing PRs as succeeding. Switch to using "fail-fast: false". Signed-off-by: Jussi Maki --- .github/workflows/pr.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 2ab2312..930bbe4 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -10,6 +10,8 @@ env: jobs: test: runs-on: ubuntu-latest + strategy: + fail-fast: false steps: - uses: actions/setup-go@v2 with: @@ -36,7 +38,6 @@ jobs: echo '```' >> results.comment - name: results - if: always() uses: thollander/actions-comment-pull-request@v2 with: comment_tag: results From 525603058479e1a60002678253711453f391087a Mon Sep 17 00:00:00 2001 From: Jussi Maki Date: Thu, 7 Nov 2024 17:22:35 +0100 Subject: [PATCH 2/2] test failure Signed-off-by: Jussi Maki --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index c27f5c8..c3c0afc 100644 --- a/Makefile +++ b/Makefile @@ -6,6 +6,7 @@ build: go build ./... test: + aoeusth go test ./... -cover -vet=all -test.count 1 test-race: