Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Pipes in Markdown tables are not handled correctly #3340

Open
z63d opened this issue Jan 25, 2025 · 1 comment
Open

docs: Pipes in Markdown tables are not handled correctly #3340

z63d opened this issue Jan 25, 2025 · 1 comment
Labels
kind/bug Something isn't working

Comments

@z63d
Copy link
Contributor

z63d commented Jan 25, 2025

What happened?

There is a display problem because pipe is used in the Markdown tables. The string after pipe is not displayed.
https://tetragon.io/docs/reference/helm-chart/
https://github.com/cilium/tetragon/blob/main/install/kubernetes/tetragon/README.md

For example, this part

| tetragon.redactionFilters | string | `""` | Filters to redact secrets from the args fields in Tetragon events. To perform redactions, redaction filters define RE2 regular expressions in the `redact` field. Any capture groups in these RE2 regular expressions are redacted and replaced with "*****". For more control, you can select which binary or binaries should have their arguments redacted with the `binary_regex` field. NOTE: This feature uses RE2 as its regular expression library. Make sure that you follow RE2 regular expression guidelines as you may observe unexpected results otherwise. More information on RE2 syntax can be found [here](https://github.com/google/re2/wiki/Syntax). NOTE: When writing regular expressions in JSON, it is important to escape backslash characters. For instance `\Wpasswd\W?` would be written as `{"redact": "\\Wpasswd\\W?"}`. As a concrete example, the following will redact all passwords passed to processes with the "--password" argument: {"redact": ["--password(?:\\s+|=)(\\S*)"]} Now, an event which contains the string "--password=foo" would have that string replaced with "--password=*****". Suppose we also see some passwords passed via the -p shorthand for a specific binary, foo. We can also redact these as follows: {"binary_regex": ["(?:^|/)foo$"], "redact": ["-p(?:\\s+|=)(\\S*)"]} With both of the above redaction filters in place, we are now redacting all password arguments. |

I'm hoping for it to be like this:

Filters to redact secrets from the args fields in Tetragon events. To perform redactions, redaction filters define RE2 regular expressions in the `redact` field. Any capture groups in these RE2 regular expressions are redacted and replaced with "*****". For more control, you can select which binary or binaries should have their arguments redacted with the `binary_regex` field. NOTE: This feature uses RE2 as its regular expression library. Make sure that you follow RE2 regular expression guidelines as you may observe unexpected results otherwise. More information on RE2 syntax can be found [here](https://github.com/google/re2/wiki/Syntax). NOTE: When writing regular expressions in JSON, it is important to escape backslash characters. For instance `\Wpasswd\W?` would be written as `{"redact": "\\Wpasswd\\W?"}`. As a concrete example, the following will redact all passwords passed to processes with the "--password" argument: {"redact": ["--password(?:\\s+|=)(\\S*)"]} Now, an event which contains the string "--password=foo" would have that string replaced with "--password=*****". Suppose we also see some passwords passed via the -p shorthand for a specific binary, foo. We can also redact these as follows: {"binary_regex": ["(?:^|/)foo$"], "redact": ["-p(?:\\s+|=)(\\S*)"]} With both of the above redaction filters in place, we are now redacting all password arguments.

But in reality it will be displayed as follows:

Filters to redact secrets from the args fields in Tetragon events. To perform redactions, redaction filters define RE2 regular expressions in the `redact` field. Any capture groups in these RE2 regular expressions are redacted and replaced with "*****". For more control, you can select which binary or binaries should have their arguments redacted with the `binary_regex` field. NOTE: This feature uses RE2 as its regular expression library. Make sure that you follow RE2 regular expression guidelines as you may observe unexpected results otherwise. More information on RE2 syntax can be found [here](https://github.com/google/re2/wiki/Syntax). NOTE: When writing regular expressions in JSON, it is important to escape backslash characters. For instance `\Wpasswd\W?` would be written as `{"redact": "\\Wpasswd\\W?"}`. As a concrete example, the following will redact all passwords passed to processes with the "--password" argument: {"redact": ["--password(?:\\s+

ref

Same bug

Tetragon Version

Not required

Kernel Version

Not required

Kubernetes Version

Bugtool

No response

Relevant log output

Anything else?

No response

@z63d z63d added the kind/bug Something isn't working label Jan 25, 2025
@mtardy
Copy link
Member

mtardy commented Jan 27, 2025

So this is not really a Tetragon issue I would say since we cannot fix it here, but more of an issue from helm-docs that seems abandoned: you could add a comment in norwoodj/helm-docs#118 that you bumped into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants