From d14c523b0951ed1dad94c829cba49241974e492c Mon Sep 17 00:00:00 2001 From: Andrew Tayman Date: Mon, 9 Feb 2015 00:10:28 -0500 Subject: [PATCH 1/2] adding toggle to the scope --- off-canvas.js | 10 ++++++---- off-canvas.min.js | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/off-canvas.js b/off-canvas.js index 8a62412..4e7c674 100644 --- a/off-canvas.js +++ b/off-canvas.js @@ -33,8 +33,14 @@ angular.module('cn.offCanvas', []) }); } + function toggle() { + this.isOpened = !this.isOpened; + container.toggleClass(containerClass); + } + html.then(function(html) { var scope = $rootScope.$new(); + scope.toggle = toggle; var ctrl = $controller(controller, {$scope: scope}); if(controllerAs) { scope[controllerAs] = ctrl; @@ -44,10 +50,6 @@ angular.module('cn.offCanvas', []) $compile(element)(scope); }) - function toggle() { - this.isOpened = !this.isOpened; - container.toggleClass(containerClass); - } return { toggle: toggle, diff --git a/off-canvas.min.js b/off-canvas.min.js index f7b93b6..2eeb7d1 100644 --- a/off-canvas.min.js +++ b/off-canvas.min.js @@ -1 +1 @@ -"use strict";angular.module("cn.offCanvas",[]).factory("cnOffCanvas",["$compile","$rootScope","$controller","$http","$templateCache","$q",function($compile,$rootScope,$controller,$http,$templateCache,$q){return function(config){function toggle(){this.isOpened=!this.isOpened,container.toggleClass(containerClass)}if(+!!config.template+ +!!config.templateUrl!==1)throw new Error;var html,container=angular.element(config.container||document.body),containerClass=config.containerClass||"is-off-canvas-opened",controller=config.controller||angular.noop,controllerAs=config.controllerAs,element=null;if(config.template){var deferred=$q.defer();deferred.resolve(config.template),html=deferred.promise}else html=$http.get(config.templateUrl,{cache:$templateCache}).then(function(response){return response.data});return html.then(function(html){var scope=$rootScope.$new(),ctrl=$controller(controller,{$scope:scope});controllerAs&&(scope[controllerAs]=ctrl),element=angular.element(html),container.prepend(element),$compile(element)(scope)}),{toggle:toggle,isOpened:!1}}}]); +"use strict";angular.module("cn.offCanvas",[]).factory("cnOffCanvas",["$compile","$rootScope","$controller","$http","$templateCache","$q",function($compile,$rootScope,$controller,$http,$templateCache,$q){return function(config){function toggle(){this.isOpened=!this.isOpened,container.toggleClass(containerClass)}if(+!!config.template+ +!!config.templateUrl!==1)throw new Error;var html,container=angular.element(config.container||document.body),containerClass=config.containerClass||"is-off-canvas-opened",controller=config.controller||angular.noop,controllerAs=config.controllerAs,element=null;if(config.template){var deferred=$q.defer();deferred.resolve(config.template),html=deferred.promise}else html=$http.get(config.templateUrl,{cache:$templateCache}).then(function(response){return response.data});return html.then(function(html){var scope=$rootScope.$new();scope.toggle=toggle;var ctrl=$controller(controller,{$scope:scope});controllerAs&&(scope[controllerAs]=ctrl),element=angular.element(html),container.prepend(element),$compile(element)(scope)}),{toggle:toggle,isOpened:!1}}}]); \ No newline at end of file From 14eeee1d227c1053d6ba1f635a184f253748f58d Mon Sep 17 00:00:00 2001 From: Andrew Tayman Date: Mon, 9 Feb 2015 00:14:59 -0500 Subject: [PATCH 2/2] adding isOpened to scope as well --- off-canvas.js | 4 +++- off-canvas.min.js | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/off-canvas.js b/off-canvas.js index 4e7c674..e712dda 100644 --- a/off-canvas.js +++ b/off-canvas.js @@ -33,6 +33,7 @@ angular.module('cn.offCanvas', []) }); } + var isOpened = false; function toggle() { this.isOpened = !this.isOpened; container.toggleClass(containerClass); @@ -41,6 +42,7 @@ angular.module('cn.offCanvas', []) html.then(function(html) { var scope = $rootScope.$new(); scope.toggle = toggle; + scope.isOpened = isOpened; var ctrl = $controller(controller, {$scope: scope}); if(controllerAs) { scope[controllerAs] = ctrl; @@ -53,7 +55,7 @@ angular.module('cn.offCanvas', []) return { toggle: toggle, - isOpened: false + isOpened: isOpened } } }); \ No newline at end of file diff --git a/off-canvas.min.js b/off-canvas.min.js index 2eeb7d1..2019128 100644 --- a/off-canvas.min.js +++ b/off-canvas.min.js @@ -1 +1 @@ -"use strict";angular.module("cn.offCanvas",[]).factory("cnOffCanvas",["$compile","$rootScope","$controller","$http","$templateCache","$q",function($compile,$rootScope,$controller,$http,$templateCache,$q){return function(config){function toggle(){this.isOpened=!this.isOpened,container.toggleClass(containerClass)}if(+!!config.template+ +!!config.templateUrl!==1)throw new Error;var html,container=angular.element(config.container||document.body),containerClass=config.containerClass||"is-off-canvas-opened",controller=config.controller||angular.noop,controllerAs=config.controllerAs,element=null;if(config.template){var deferred=$q.defer();deferred.resolve(config.template),html=deferred.promise}else html=$http.get(config.templateUrl,{cache:$templateCache}).then(function(response){return response.data});return html.then(function(html){var scope=$rootScope.$new();scope.toggle=toggle;var ctrl=$controller(controller,{$scope:scope});controllerAs&&(scope[controllerAs]=ctrl),element=angular.element(html),container.prepend(element),$compile(element)(scope)}),{toggle:toggle,isOpened:!1}}}]); \ No newline at end of file +"use strict";angular.module("cn.offCanvas",[]).factory("cnOffCanvas",["$compile","$rootScope","$controller","$http","$templateCache","$q",function($compile,$rootScope,$controller,$http,$templateCache,$q){return function(config){function toggle(){this.isOpened=!this.isOpened,container.toggleClass(containerClass)}if(+!!config.template+ +!!config.templateUrl!==1)throw new Error;var html,container=angular.element(config.container||document.body),containerClass=config.containerClass||"is-off-canvas-opened",controller=config.controller||angular.noop,controllerAs=config.controllerAs,element=null;if(config.template){var deferred=$q.defer();deferred.resolve(config.template),html=deferred.promise}else html=$http.get(config.templateUrl,{cache:$templateCache}).then(function(response){return response.data});var isOpened=!1;return html.then(function(html){var scope=$rootScope.$new();scope.toggle=toggle,scope.isOpened=isOpened;var ctrl=$controller(controller,{$scope:scope});controllerAs&&(scope[controllerAs]=ctrl),element=angular.element(html),container.prepend(element),$compile(element)(scope)}),{toggle:toggle,isOpened:isOpened}}}]); \ No newline at end of file