Added fixes for logs and for local image. (#541)

Co-authored-by: [email protected] <[email protected]>

Author: raresgaia123

dashboard/src/components/custom-node-no-interaction/CustomNodeNoInteraction.tsx

@@ -33,10 +33,11 @@ interface Props {
       log: string,
       isInteractive: boolean,
       menuItems?: NodeMenuItem[],
+      taskId: string;
     };
 }
 
-const CustomNodeNoInteraction = ({ data: { status, label, isInteractive, menuItems } }: Props) => {
+const CustomNodeNoInteraction = ({ data: { status, label, isInteractive, menuItems, taskId } }: Props) => {
   const connectionNodeId = useStore(connectionNodeIdSelector);
   const [ statusColor, setStatusColor ] = useState('green');
   const [ tooltip, setTooltip ] = useState('green');
@@ -69,7 +70,7 @@ const CustomNodeNoInteraction = ({ data: { status, label, isInteractive, menuIte
               <PopoverBody>
                 {
                   menuItems.map(item =>
-                    <Box className="custom-node-no-interaction-menu-item" key={item.label} onClick={() => { item.callback({ taskName: label, tasks: item.tasks }) }}>
+                    <Box className="custom-node-no-interaction-menu-item" key={item.label} onClick={() => { item.callback({ taskName: label, taskId, tasks: item.tasks }) }}>
                     { item.label }
                     </Box>
                   )

dashboard/src/features/job-details/components/job-topology/JobTopology.tsx

@@ -56,8 +56,8 @@ const JobTopology = ({ tasks, experiment, runs, mutate }: Props) => {
   }, [tasks])
 
 
-  const onLogsDisplay = (data: { taskName: string, tasks: Task[] }) => {
-    const taskLog = data.tasks?.find(task => task.role === data.taskName)?.log || '';
+  const onLogsDisplay = (data: { taskName: string, taskId: string, tasks: Task[] }) => {
+    const taskLog = data.tasks?.find(task => task.taskId === data.taskId)?.log || '';
     setTaskName(data.taskName);
     setTaskLog(taskLog);
     onOpen();
@@ -68,8 +68,9 @@ const JobTopology = ({ tasks, experiment, runs, mutate }: Props) => {
       const edges = getEdges(tasks);
       const nodes = getNodes(
         getTasksWithLevelsAndCounts(tasks).map(task => ({
-          ...task,
-          menuItems: getNodeMenuOptions(task)
+            ...task,
+            menuItems: getNodeMenuOptions(task),
+            taskId: task.taskId
         }))
       );
       const layouted = getGraphLayoutedElements(nodes, edges, 'TB', 200, 200);

dashboard/src/features/job-details/components/task-logs/TaskLogs.tsx

@@ -1,9 +1,6 @@
-import { Box, Icon, IconButton, Menu, MenuButton, Text, MenuItem, MenuList, Modal, ModalBody, ModalCloseButton, ModalContent, ModalHeader, ModalOverlay, Table, TableContainer, Tbody, Td, Th, Thead, Tr } from '@chakra-ui/react'
-import { colors } from '@mui/material';
+import { Text, Modal, ModalBody, ModalCloseButton, ModalContent, ModalHeader, ModalOverlay, Table, TableContainer, Tbody, Td, Th, Thead, Tr } from '@chakra-ui/react'
 import React, { useEffect, useRef, useState } from 'react'
-import { FaEllipsisVertical } from 'react-icons/fa6';
 import { COLORS } from '../../../../constants';
-import { Design } from '../../../../entities/Design';
 import { getMappedLogs } from '../../utils';
 
 interface Props {

dashboard/src/features/job-details/utils.ts

@@ -108,7 +108,8 @@ export const getNodes = (tasks: Task[]) => {
         label: task.role,
         id: task.taskId,
         status: task.state,
-        menuItems: task.menuItems
+        menuItems: task.menuItems,
+        taskId: task.taskId
       },
       position: { x: 0, y: 0 },
       type: 'customNodeNoInteraction',

fiab/helm-chart/control/values.yaml

@@ -63,10 +63,10 @@ minio:
     hosts:
       - minio.flame.test
 
-imageName: ciscoresearch/flame
-imageTag: v0.4.0
-workerImageName: ciscoresearch/flame
-workerImageTag: v0.4.0
+imageName: flame
+imageTag: dev
+workerImageName: flame
+workerImageTag: dev
 
 broker:
   - sort: mqtt